From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757262AbdKOLNE (ORCPT ); Wed, 15 Nov 2017 06:13:04 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:55730 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753029AbdKOLM7 (ORCPT ); Wed, 15 Nov 2017 06:12:59 -0500 Date: Wed, 15 Nov 2017 11:12:51 +0000 From: Russell King - ARM Linux To: Maciej Purski Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH] component: add debugfs support Message-ID: <20171115111250.GC31757@n2100.armlinux.org.uk> References: <1510743866-21636-1-git-send-email-m.purski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1510743866-21636-1-git-send-email-m.purski@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 15, 2017 at 12:04:26PM +0100, Maciej Purski wrote: > +static void component_master_debugfs_add(struct master *m); > +static void component_master_debugfs_del(struct master *m); Please avoid forward declarations. > +static int component_devices_show(struct seq_file *s, void *data) > +{ > + struct master *m = s->private; > + struct component_match *match = m->match; > + size_t i; > + > + mutex_lock(&component_mutex); > + seq_puts(s, "master name status\n"); Would: seq_printf(s, "%-40s %20s\n", "master name", "status"); be better - it becomes more obvious what is intended (that is for the headings to line up with the data below.) > + seq_puts(s, "-------------------------------------------------------------\n"); > + seq_printf(s, "%-40s %20s\n\n", > + dev_name(m->dev), m->bound ? "bound" : "not bound"); > + > + seq_puts(s, "device name status\n"); Ditto. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up