From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932686AbdKONZl (ORCPT ); Wed, 15 Nov 2017 08:25:41 -0500 Received: from mx2.suse.de ([195.135.220.15]:51076 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932115AbdKONZ3 (ORCPT ); Wed, 15 Nov 2017 08:25:29 -0500 Date: Wed, 15 Nov 2017 14:25:27 +0100 From: Jan Kara To: Jeff Layton Cc: reiserfs-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] reiserfs: remove unneeded i_version bump Message-ID: <20171115132527.GA13707@quack2.suse.cz> References: <20171030152015.9444-1-jlayton@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171030152015.9444-1-jlayton@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 30-10-17 11:20:15, Jeff Layton wrote: > From: Jeff Layton > > The i_version field in reiserfs is not initialized and is only ever > updated here. Nothing ever views it, so just remove it. > > Signed-off-by: Jeff Layton Thanks! I've added this patch to my tree. Honza > --- > fs/reiserfs/super.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c > index 5464ec517702..4885c7b6e44f 100644 > --- a/fs/reiserfs/super.c > +++ b/fs/reiserfs/super.c > @@ -2591,7 +2591,6 @@ static ssize_t reiserfs_quota_write(struct super_block *sb, int type, > return err; > if (inode->i_size < off + len - towrite) > i_size_write(inode, off + len - towrite); > - inode->i_version++; > inode->i_mtime = inode->i_ctime = current_time(inode); > mark_inode_dirty(inode); > return len - towrite; > -- > 2.13.6 > -- Jan Kara SUSE Labs, CR