From: Mel Gorman <mgorman@techsingularity.net>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
yasu.isimatu@gmail.com, koki.sanagi@us.fujitsu.com
Subject: Re: [PATCH] mm, meminit: Serially initialise deferred memory if trace_buf_size is specified
Date: Wed, 15 Nov 2017 14:43:14 +0000 [thread overview]
Message-ID: <20171115144314.xwdi2sbcn6m6lqdo@techsingularity.net> (raw)
In-Reply-To: <20171115142816.zxdgkad3ch2bih6d@dhcp22.suse.cz>
On Wed, Nov 15, 2017 at 03:28:16PM +0100, Michal Hocko wrote:
> On Wed 15-11-17 14:13:29, Mel Gorman wrote:
> [...]
> > I doubt anyone well. Even the original reporter appeared to pick that
> > particular value just to trigger the OOM.
>
> Then why do we care at all? The trace buffer size can be configured from
> the userspace if it is not sufficiently large IIRC.
>
I guess there is the potential that the trace buffer needs to be large
enough early on in boot but I'm not sure why it would need to be that large
to be honest. Bottom line, it's fairly trivial to just serialise meminit
in the event that it's resized from command line. I'm also ok with just
leaving this is as a "don't set the buffer that large" but I don't think
spreading meminit concerns into ftrace is a good idea.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2017-11-15 14:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 8:55 Mel Gorman
2017-11-15 11:55 ` Michal Hocko
2017-11-15 14:13 ` Mel Gorman
2017-11-15 14:28 ` Michal Hocko
2017-11-15 14:43 ` Mel Gorman [this message]
2017-11-15 14:57 ` Michal Hocko
2017-11-15 19:17 ` YASUAKI ISHIMATSU
2017-11-16 8:54 ` Michal Hocko
2017-11-16 10:06 ` Mel Gorman
2017-11-17 18:19 ` Pavel Tatashin
2017-11-17 21:32 ` Mel Gorman
2017-11-30 3:41 ` Pavel Tatashin
2017-12-06 10:50 ` Mel Gorman
2018-01-31 17:28 ` Koki.Sanagi
2018-01-31 18:24 ` Pavel Tatashin
2018-02-05 14:14 ` Masayoshi Mizuma
2018-02-05 15:26 ` Pavel Tatashin
2017-11-21 1:04 ` Andrew Morton
2017-11-30 3:49 ` Pavel Tatashin
2017-11-15 19:49 ` Andrew Morton
2017-11-16 8:39 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171115144314.xwdi2sbcn6m6lqdo@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=koki.sanagi@us.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®