From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758429AbdKOPPj (ORCPT ); Wed, 15 Nov 2017 10:15:39 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:54528 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751117AbdKOPPc (ORCPT ); Wed, 15 Nov 2017 10:15:32 -0500 Date: Wed, 15 Nov 2017 16:15:37 +0100 From: Greg Kroah-Hartman To: Patrick =?iso-8859-1?Q?Br=FCnn?= Cc: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Shawn Guo , Sasha Levin , Ben Hutchings Subject: Re: [PATCH 4.4 05/56] ARM: dts: imx53-qsb-common: fix FEC pinmux config Message-ID: <20171115151537.GB13671@kroah.com> References: <20171113125557.613444087@linuxfoundation.org> <20171113125558.340246464@linuxfoundation.org> <1510674274.18523.31.camel@codethink.co.uk> <3BB206AB2B1BD448954845CE6FF69A8E01CB52F6BA@NT-Mail07.beckhoff.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3BB206AB2B1BD448954845CE6FF69A8E01CB52F6BA@NT-Mail07.beckhoff.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 15, 2017 at 04:03:51AM +0000, Patrick Brünn wrote: > >From: Ben Hutchings [mailto:ben.hutchings@codethink.co.uk] > >Sent: Dienstag, 14. November 2017 16:45 > >> 4.4-stable review patch. If anyone has any objections, please let me know. > >> > >> ------------------ > >> > >> From: Patrick Bruenn > >> > >> > >> [ Upstream commit 8b649e426336d7d4800ff9c82858328f4215ba01 ] > >> > >> The pinmux configuration in device tree was different from manual > >> muxing in /board/freescale/mx53loco/mx53loco.c > >> All pins were configured as NO_PAD_CTL(1 << 31), which was fine as the > >> bootloader already did the correct pinmuxing for us. > >> But recently u-boot is migrating to reuse device tree files from the > >> kernel tree, so it seems to be better to have the correct pinmuxing in > >> our files, too. > >[...] > > > >Presumably u-boot will reuse the *upstream* device tree files, which > >implies this doesn't need to be fixed on stable branches. > > > >Ben. > I think Ben made a good point. It might be dangerous to change the pinmux > configuration for an Ethernet controller in stable kernels, just in case > anyone out there uses a hardware and bootloader with different muxing. > Shawn might be able to tell, if that is even possible. > In case there is at least a chance someone is using a different configuration, > I wouldn't backport this commit to any stable branch. Ok, thanks, now dropped from the 4.4-stable queue. greg k-h