From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933304AbdKORLe (ORCPT ); Wed, 15 Nov 2017 12:11:34 -0500 Received: from mail-qt0-f173.google.com ([209.85.216.173]:46696 "EHLO mail-qt0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757115AbdKORLV (ORCPT ); Wed, 15 Nov 2017 12:11:21 -0500 X-Google-Smtp-Source: AGs4zMb7Dv7sM8Lcp9oEVYzsBG9b7lNjH3NUF/vPpFIgRLsYY1tEsWaeAwc10JrYa9+Qfw46Wsi4Zg== Date: Wed, 15 Nov 2017 09:11:18 -0800 From: Tejun Heo To: Shaohua Li Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, kernel-team@fb.com, lizefan@huawei.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, guro@fb.com Subject: Re: [PATCH v2 3/7] blkcg: associate a request with its blkcg_gq instead of request_list Message-ID: <20171115171118.GV983427@devbig577.frc2.facebook.com> References: <20171112222613.3613362-1-tj@kernel.org> <20171112222613.3613362-4-tj@kernel.org> <20171113201523.GM983427@devbig577.frc2.facebook.com> <20171114231743.2eprnbfmgesqc42c@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171114231743.2eprnbfmgesqc42c@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Tue, Nov 14, 2017 at 03:17:43PM -0800, Shaohua Li wrote: > After patch 5, we don't really need the blk_put_rl, blk_get_rl, blk_rq_set_rl > functions. I'd like to delete them and only keep blk_rq_rl. The name > blk_rq_set_rl is confusing too. Yeah, we can switch the legacy rq to switch to direct blkg pinning too. If that cleans up the code, great. Thanks. -- tejun