mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: David Daney <david.daney@cavium.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
	James Hogan <james.hogan@mips.com>,
	netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	Mark Rutland <mark.rutland@arm.com>,
	devel@driverdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	"Steven J. Hill" <steven.hill@cavium.com>,
	devicetree@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Carlos Munoz <cmunoz@cavium.com>
Subject: Re: [PATCH v3 1/8] dt-bindings: Add Cavium Octeon Common Ethernet Interface.
Date: Wed, 15 Nov 2017 13:18:57 -0600	[thread overview]
Message-ID: <20171115191857.podohd56knfd4hyh@rob-hp-laptop> (raw)
In-Reply-To: <20171109192915.11912-2-david.daney@cavium.com>

On Thu, Nov 09, 2017 at 11:29:08AM -0800, David Daney wrote:
> From: Carlos Munoz <cmunoz@cavium.com>
> 
> Add bindings for Common Ethernet Interface (BGX) block.
> 
> Signed-off-by: Carlos Munoz <cmunoz@cavium.com>
> Signed-off-by: Steven J. Hill <Steven.Hill@cavium.com>
> Signed-off-by: David Daney <david.daney@cavium.com>
> ---
>  .../devicetree/bindings/net/cavium-bgx.txt         | 61 ++++++++++++++++++++++
>  1 file changed, 61 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/cavium-bgx.txt
> 
> diff --git a/Documentation/devicetree/bindings/net/cavium-bgx.txt b/Documentation/devicetree/bindings/net/cavium-bgx.txt
> new file mode 100644
> index 000000000000..6b1f8b994c20
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/cavium-bgx.txt
> @@ -0,0 +1,61 @@
> +* Common Ethernet Interface (BGX) block
> +
> +Properties:
> +
> +- compatible: "cavium,octeon-7890-bgx": Compatibility with all cn7xxx SOCs.
> +
> +- reg: The base address of the BGX block.
> +
> +- #address-cells: Must be <1>.
> +
> +- #size-cells: Must be <0>.  BGX addresses have no size component.
> +
> +A BGX block has several children, each representing an Ethernet
> +interface.
> +
> +
> +* Ethernet Interface (BGX port) connects to PKI/PKO
> +
> +Properties:
> +
> +- compatible: "cavium,octeon-7890-bgx-port": Compatibility with all
> +	      cn7xxx SOCs.
> +
> +	      "cavium,octeon-7360-xcv": Compatibility with cn73xx SOCs
> +	      for RGMII.
> +
> +- reg: The index of the interface within the BGX block.

There's no memory mapped region associated with the sub-blocks?

> +
> +Optional properties:
> +
> +- local-mac-address: Mac address for the interface.
> +
> +- phy-handle: phandle to the phy node connected to the interface.
> +
> +- phy-mode: described in ethernet.txt.
> +
> +- fixed-link: described in fixed-link.txt.
> +
> +Example:
> +
> +	ethernet-mac-nexus@11800e0000000 {
> +		compatible = "cavium,octeon-7890-bgx";
> +		reg = <0x00011800 0xe0000000 0x00000000 0x01000000>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		ethernet-mac@0 {

ethernet@0

> +			compatible = "cavium,octeon-7360-xcv";
> +			reg = <0>;
> +			local-mac-address = [ 00 01 23 45 67 89 ];
> +			phy-handle = <&phy3>;
> +			phy-mode = "rgmii-rxid"
> +		};
> +		ethernet-mac@1 {

ditto.

Otherwise,

Acked-by: Rob Herring <robh@kernel.org>

> +			compatible = "cavium,octeon-7890-bgx-port";
> +			reg = <1>;
> +			local-mac-address = [ 00 01 23 45 67 8a ];
> +			phy-handle = <&phy4>;
> +			phy-mode = "sgmii"
> +		};
> +	};
> -- 
> 2.13.6
> 

  reply	other threads:[~2017-11-15 19:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-09 19:29 [PATCH v3 0/8] Cavium OCTEON-III network driver David Daney
2017-11-09 19:29 ` [PATCH v3 1/8] dt-bindings: Add Cavium Octeon Common Ethernet Interface David Daney
2017-11-15 19:18   ` Rob Herring [this message]
2017-11-15 19:30     ` David Daney
2017-11-09 19:29 ` [PATCH v3 2/8] MIPS: Octeon: Enable LMTDMA/LMTST operations David Daney
2017-11-09 19:29 ` [PATCH v3 3/8] MIPS: Octeon: Add a global resource manager David Daney
2017-11-09 19:29 ` [PATCH v3 4/8] MIPS: Octeon: Add Free Pointer Unit (FPA) support David Daney
2017-11-09 19:29 ` [PATCH v3 5/8] MIPS: Octeon: Automatically provision CVMSEG space David Daney
2017-11-09 19:29 ` [PATCH v3 6/8] staging: octeon: Remove USE_ASYNC_IOBDMA macro David Daney
2017-11-09 19:29 ` [PATCH v3 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support David Daney
2017-11-09 22:23   ` Andrew Lunn
2017-11-09 22:29   ` Andrew Lunn
2017-11-09 19:29 ` [PATCH v3 8/8] MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-* David Daney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171115191857.podohd56knfd4hyh@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=cmunoz@cavium.com \
    --cc=davem@davemloft.net \
    --cc=david.daney@cavium.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=james.hogan@mips.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    --cc=steven.hill@cavium.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®