From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758212AbdKOWBR (ORCPT ); Wed, 15 Nov 2017 17:01:17 -0500 Received: from 19pmail.ess.barracuda.com ([64.235.154.231]:48187 "EHLO 19pmail.ess.barracuda.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753297AbdKOWBI (ORCPT ); Wed, 15 Nov 2017 17:01:08 -0500 Date: Wed, 15 Nov 2017 21:59:11 +0000 From: James Hogan To: Aleksandar Markovic CC: , Miodrag Dinic , "Goran Ferenc" , Aleksandar Markovic , "David S. Miller" , Douglas Leung , Greg Kroah-Hartman , , "Mauro Carvalho Chehab" , Paul Burton , "Petar Jovanovic" , Raghu Gandham , Ralf Baechle , Randy Dunlap Subject: Re: [PATCH v9 3/3] MIPS: ranchu: Add Ranchu as a new generic-based board Message-ID: <20171115215910.GB27409@jhogan-linux.mipstec.com> References: <1510753368-16453-1-git-send-email-aleksandar.markovic@rt-rk.com> <1510753368-16453-4-git-send-email-aleksandar.markovic@rt-rk.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="neYutvxvOLaeuPCA" Content-Disposition: inline In-Reply-To: <1510753368-16453-4-git-send-email-aleksandar.markovic@rt-rk.com> User-Agent: Mutt/1.7.2 (2016-11-26) X-Originating-IP: [192.168.154.110] X-BESS-ID: 1510783162-452059-26974-13054-1 X-BESS-VER: 2017.14.1-r1710272128 X-BESS-Apparent-Source-IP: 12.201.5.28 X-BESS-Outbound-Spam-Score: 0.60 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.186970 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound 0.60 MARKETING_SUBJECT HEADER: Subject contains popular marketing words X-BESS-Outbound-Spam-Status: SCORE=0.60 using account:ESS59374 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND, MARKETING_SUBJECT X-BESS-BRTS-Status: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --neYutvxvOLaeuPCA Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Hi Aleksandar, On Wed, Nov 15, 2017 at 02:42:20PM +0100, Aleksandar Markovic wrote: > diff --git a/arch/mips/configs/generic/board-ranchu.config b/arch/mips/configs/generic/board-ranchu.config > new file mode 100644 > index 0000000..fee9ad4 > --- /dev/null > +++ b/arch/mips/configs/generic/board-ranchu.config > @@ -0,0 +1,30 @@ > +CONFIG_VIRT_BOARD_RANCHU=y I presume its valid for Ranchu support to be enabled in MIPS32 / MIPS64, and R1 / R2 / R6 kernels? (that's fine if so, just making sure there's no need for a require comment). > diff --git a/arch/mips/generic/board-ranchu.c b/arch/mips/generic/board-ranchu.c > new file mode 100644 > index 0000000..0efc555 > --- /dev/null > +++ b/arch/mips/generic/board-ranchu.c > @@ -0,0 +1,85 @@ ... > +static __init unsigned int ranchu_measure_hpt_freq(void) > +{ ... > + count += 5000; /* round */ > + count -= count % 10000; A comment to explain the purpose of the rounding would be helpful. I presume its there just to get a more accurate value since the frequency will always be a round value in practice. Either way this patch looks good to me: Reviewed-by: James Hogan Thanks! James --neYutvxvOLaeuPCA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEd80NauSabkiESfLYbAtpk944dnoFAloMuKgACgkQbAtpk944 dnpeFw/8DExi8wFBAdaH20u+iGqOc0Kpxl2KyV+on+yt9EDVHizax+NfYj50Upqc h8B1TVGUTGFFwv0PzaddABszwepRM+uhRvnLn+WLgENt+UUFPehF8UTE1h5tFgqO VUJqxYbvLmicsF0W3HpMlyWbr4CZibyhftPb/mZonwifaJbHKgslXYttGG4D903j prhUTN7o8Hnkt2q+sV3fyGgO2nC3Ex5oSVeDDNTxQNxqK8oNSrslq2lTOhXuMO++ b/sbT6EZSnQ/GPnSUJrHuHgcVsAGRQwhQCZwC1uMm7sjkMxpcffKpUWE/NJLQuk8 GuBlRw6y68KbvrNDZ2iQWZB09VQfe8DxoC5Axw2/6F+PwGuCDWOI0mcAf18p0mGC a8zA5yZ1VpbRhwZnR2YrQIA+Ozlv7U79EA0iiCFfSEF9uoKLre7J4FpeN+RdsG9y N7w2X6TZOVrBHbHWUMe1hZTdUd29Vy24OLflhcHRkdovz4aG1NYabU5RfMSZnU47 QP4h7OOYkzWVuY6F5k3BhvJaEiV9ML2HeDwg92/GqI6soqU601B2r+EKK5eGcF3z Dcw/fuVyKtgzCWMj4K2jneugKZuStUcbskoBsz8Qtqu2FJ/ZhYnHopzLVFYQAWL/ TYIK7m9hOVLEaeY+xytdBXyJEHOP1VbE+h3Ufu2fMfZJ9YYCbbQ= =vr0Q -----END PGP SIGNATURE----- --neYutvxvOLaeuPCA--