From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933425AbdKOW2E (ORCPT <rfc822;w@1wt.eu>);
        Wed, 15 Nov 2017 17:28:04 -0500
Received: from mail-pg0-f67.google.com ([74.125.83.67]:52961 "EHLO
        mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1757171AbdKOW14 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 15 Nov 2017 17:27:56 -0500
X-Google-Smtp-Source: AGs4zMbacSDo8JKqBNycVTDgY/TqrHId35lmEhOtGgdOtLGCR4o3nr3DToJ/lpuz1/SVIDyS67pyVg==
Date: Wed, 15 Nov 2017 14:27:53 -0800
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
        Wei-Ning Huang <wnhuang@google.com>
Subject: Re: [PATCH 1/3] firmware: vpd: Destroy vpd sections in remove
 function
Message-ID: <20171115222753.2varriltddvoxtrp@dtor-ws>
References: <1510779645-13052-1-git-send-email-linux@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1510779645-13052-1-git-send-email-linux@roeck-us.net>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 15, 2017 at 01:00:43PM -0800, Guenter Roeck wrote:
> vpd sections are initialized during probe and thus should be destroyed
> in the remove function.
> 
> Fixes: 049a59db34eb ("firmware: Google VPD sysfs driver")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

> ---
>  drivers/firmware/google/vpd.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c
> index 35e553b3b190..84217172297b 100644
> --- a/drivers/firmware/google/vpd.c
> +++ b/drivers/firmware/google/vpd.c
> @@ -298,8 +298,17 @@ static int vpd_probe(struct platform_device *pdev)
>  	return vpd_sections_init(entry.cbmem_addr);
>  }
>  
> +static int vpd_remove(struct platform_device *pdev)
> +{
> +	vpd_section_destroy(&ro_vpd);
> +	vpd_section_destroy(&rw_vpd);
> +
> +	return 0;
> +}
> +
>  static struct platform_driver vpd_driver = {
>  	.probe = vpd_probe,
> +	.remove = vpd_remove,
>  	.driver = {
>  		.name = "vpd",
>  	},
> @@ -324,8 +333,6 @@ static int __init vpd_platform_init(void)
>  
>  static void __exit vpd_platform_exit(void)
>  {
> -	vpd_section_destroy(&ro_vpd);
> -	vpd_section_destroy(&rw_vpd);
>  	kobject_put(vpd_kobj);
>  }
>  
> -- 
> 2.7.4
> 

-- 
Dmitry