From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933858AbdKOXeA (ORCPT ); Wed, 15 Nov 2017 18:34:00 -0500 Received: from violet.fr.zoreil.com ([92.243.8.30]:55656 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753297AbdKOXd4 (ORCPT ); Wed, 15 Nov 2017 18:33:56 -0500 Date: Thu, 16 Nov 2017 00:33:43 +0100 From: Francois Romieu To: David Miller Cc: kai.heng.feng@canonical.com, nic_swsd@realtek.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, hayeswang@realtek.com, jrg.otte@gmail.com Subject: Re: [PATCH 1/2] r8169: reinstate ALDPS for power saving Message-ID: <20171115233343.GA28812@electric-eye.fr.zoreil.com> References: <20171115090019.23972-1-kai.heng.feng@canonical.com> <20171115.195306.1005850318419905294.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171115.195306.1005850318419905294.davem@davemloft.net> X-Organisation: Land of Sunshine Inc. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Miller : [...] > The amount of coverage this change is going to get is very small as > well, meaning an even greater chance of regressions. Yes. > Therefore the only acceptable way to handle this is to have > a white-list, specific chips that have been explicitly tested > and are known to work with this feature, rather than the other > way around. > > Furthermore, you're not even checking the chip version, you're > checking instead whether the firmware is loaded or not. That > doesn't seem like a safe way to guard this at all. Actually the chip specific xyz_hw_phy_config methods call the relevant aldps enabling helper _but_ the 8168evl dedicated xyz_hw_phy_config doesn't. The firmware loaded check is just a distraction for the busy reviewer. -- Ueimor