From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753976AbdKOXw5 (ORCPT ); Wed, 15 Nov 2017 18:52:57 -0500 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:38017 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757723AbdKOXws (ORCPT ); Wed, 15 Nov 2017 18:52:48 -0500 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: byungchul.park@lge.com X-Original-SENDERIP: 10.177.222.33 X-Original-MAILFROM: byungchul.park@lge.com Date: Thu, 16 Nov 2017 08:52:39 +0900 From: Byungchul Park To: nab@linux-iscsi.org, mst@redhat.com, jasowang@redhat.com Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@lge.com Subject: Re: [PATCH] vhost/scsi: Use safe iteration in vhost_scsi_complete_cmd_work() Message-ID: <20171115235239.GA4394@X58A-UD3R> References: <1510186649-9765-1-git-send-email-byungchul.park@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1510186649-9765-1-git-send-email-byungchul.park@lge.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 09, 2017 at 09:17:29AM +0900, Byungchul Park wrote: > I am sorry for having made a mistake on it. Hello Nicholas, Please consider this patch urgently. I'm sorry for having changed the original behavior with the previous patch. The safe version of llist API should be used to keep the original behavior. Thanks, Byungchul > -----8<----- > >From ba9a0f76dffceffa4fa3aa2d9be49cdb0d9b7d4f Mon Sep 17 00:00:00 2001 > From: Byungchul Park > Date: Thu, 9 Nov 2017 09:00:21 +0900 > Subject: [PATCH] vhost/scsi: Use safe iteration in vhost_scsi_complete_cmd_work() > > The following patch changed the behavior which originally did safe > iteration. Make it safe as it was. > > 12bdcbd539c6327c09da0503c674733cb2d82cb5 > vhost/scsi: Don't reinvent the wheel but use existing llist API > > Signed-off-by: Byungchul Park > --- > drivers/vhost/scsi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c > index 046f6d2..46539ca 100644 > --- a/drivers/vhost/scsi.c > +++ b/drivers/vhost/scsi.c > @@ -519,7 +519,7 @@ static void vhost_scsi_complete_cmd_work(struct vhost_work *work) > vs_completion_work); > DECLARE_BITMAP(signal, VHOST_SCSI_MAX_VQ); > struct virtio_scsi_cmd_resp v_rsp; > - struct vhost_scsi_cmd *cmd; > + struct vhost_scsi_cmd *cmd, *t; > struct llist_node *llnode; > struct se_cmd *se_cmd; > struct iov_iter iov_iter; > @@ -527,7 +527,7 @@ static void vhost_scsi_complete_cmd_work(struct vhost_work *work) > > bitmap_zero(signal, VHOST_SCSI_MAX_VQ); > llnode = llist_del_all(&vs->vs_completion_list); > - llist_for_each_entry(cmd, llnode, tvc_completion_list) { > + llist_for_each_entry_safe(cmd, t, llnode, tvc_completion_list) { > se_cmd = &cmd->tvc_se_cmd; > > pr_debug("%s tv_cmd %p resid %u status %#02x\n", __func__, > -- > 1.9.1