mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: gomonovych@gmail.com
Cc: Ariel.Elior@cavium.com, everest-linux-l2@cavium.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] qed: fix unnecessary call to memset cocci warnings
Date: Thu, 16 Nov 2017 10:37:50 +0900 (KST)	[thread overview]
Message-ID: <20171116.103750.1000550484486327577.davem@davemloft.net> (raw)
In-Reply-To: <1510775895-16258-1-git-send-email-gomonovych@gmail.com>

From: Vasyl Gomonovych <gomonovych@gmail.com>
Date: Wed, 15 Nov 2017 20:58:15 +0100

> @@ -1277,11 +1277,10 @@ static struct qed_dcbx_get *qed_dcbnl_get_dcbx(struct qed_hwfn *hwfn,
>  {
>  	struct qed_dcbx_get *dcbx_info;
>  
> -	dcbx_info = kmalloc(sizeof(*dcbx_info), GFP_ATOMIC);
> +	dcbx_info = kzmalloc(sizeof(*dcbx_info), GFP_ATOMIC);

Thanks for not even compile testing your patch.

  reply	other threads:[~2017-11-16  1:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-15 19:58 Vasyl Gomonovych
2017-11-16  1:37 ` David Miller [this message]
2017-11-16 21:35 ` Vasyl Gomonovych
2017-11-16 22:04 ` Vasyl Gomonovych
2017-11-17 15:59   ` Andy Shevchenko
2017-11-18  1:31   ` David Miller
2017-11-20 21:31   ` Vasyl Gomonovych

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171116.103750.1000550484486327577.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Ariel.Elior@cavium.com \
    --cc=everest-linux-l2@cavium.com \
    --cc=gomonovych@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®