From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933646AbdKPBuO (ORCPT ); Wed, 15 Nov 2017 20:50:14 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:37928 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933433AbdKPBuG (ORCPT ); Wed, 15 Nov 2017 20:50:06 -0500 Date: Thu, 16 Nov 2017 10:50:03 +0900 (KST) Message-Id: <20171116.105003.36292605113021036.davem@davemloft.net> To: mkubecek@suse.cz Cc: johannes@sipsolutions.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] genetlink: fix genlmsg_nlhdr() From: David Miller In-Reply-To: <20171115120932.A6A87A0CA8@unicorn.suse.cz> References: <20171115120932.A6A87A0CA8@unicorn.suse.cz> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 15 Nov 2017 17:50:06 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michal Kubecek Date: Wed, 15 Nov 2017 13:09:32 +0100 (CET) > According to the description, first argument of genlmsg_nlhdr() points to > what genlmsg_put() returns, i.e. beginning of user header. Therefore we > should only subtract size of genetlink header and netlink message header, > not user header. > > This also means we don't need to pass the pointer to genetlink family and > the same is true for genl_dump_check_consistent() which is the only caller > of genlmsg_nlhdr(). (Note that at the moment, these functions are only > used for families which do not have user header so that they are not > affected.) > > Fixes: 670dc2833d14 ("netlink: advertise incomplete dumps") > Signed-off-by: Michal Kubecek Applied.