From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933780AbdKPBvC (ORCPT ); Wed, 15 Nov 2017 20:51:02 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:37960 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933727AbdKPBuj (ORCPT ); Wed, 15 Nov 2017 20:50:39 -0500 Date: Thu, 16 Nov 2017 10:50:34 +0900 (KST) Message-Id: <20171116.105034.2075526380204547211.davem@davemloft.net> To: grygorii.strashko@ti.com Cc: netdev@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH] net: ethernet: ti: cpsw: fix min eth packet size From: David Miller In-Reply-To: <20171115154635.26642-1-grygorii.strashko@ti.com> References: <20171115154635.26642-1-grygorii.strashko@ti.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 15 Nov 2017 17:50:38 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Grygorii Strashko Date: Wed, 15 Nov 2017 09:46:35 -0600 > Now CPSW driver configures min eth packet size to 60 octets (ETH_ZLEN) > which works in most of cases, but when port VLAN is configured on some > switch port, it also can be configured to force all egress packets to be > VLAN untagged. And in this case, CPSW driver will pad small packets to 60 > octets, but final packet size on port egress can became less than 60 octets > due to VLAN tag removal and packet will be dropped. > > Hence, fix it by accounting VLAN header in CPSW min eth packet size. While > here, use proper defines for CPSW_MAX_PACKET_SIZE also, instead of open > coding. > > Signed-off-by: Grygorii Strashko Applied.