From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934210AbdKPNdC (ORCPT <rfc822;w@1wt.eu>);
        Thu, 16 Nov 2017 08:33:02 -0500
Received: from shards.monkeyblade.net ([184.105.139.130]:43788 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932671AbdKPNcx (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Nov 2017 08:32:53 -0500
Date: Thu, 16 Nov 2017 22:32:48 +0900 (KST)
Message-Id: <20171116.223248.608647485584566065.davem@davemloft.net>
To: arvind.yadav.cs@gmail.com
Cc: isdn@linux-pingi.de, stephen@networkplumber.org,
        johannes.berg@intel.com, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
Subject: Re: [PATCH 00/12] isdn: hisax: Fix pnp_irq's error checking
From: David Miller <davem@davemloft.net>
In-Reply-To: <cover.1510805781.git.arvind.yadav.cs@gmail.com>
References: <cover.1510805781.git.arvind.yadav.cs@gmail.com>
X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 16 Nov 2017 05:32:52 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Arvind Yadav <arvind.yadav.cs@gmail.com>
Date: Thu, 16 Nov 2017 09:57:17 +0530

> The pnp_irq() function returns -1 if an error occurs.
> pnp_irq() error checking for zero is not correct.

I can't say I like all of the mixing of "-1", and unsigned
integer values (pnp_irq() returns resource_size_t, the
IsdnCard->para[] arran entries are "unsigned long") but
what can I do.

Series applied, thanks.