From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933792AbdKPIi6 (ORCPT ); Thu, 16 Nov 2017 03:38:58 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:44227 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933545AbdKPIix (ORCPT ); Thu, 16 Nov 2017 03:38:53 -0500 Date: Thu, 16 Nov 2017 09:38:49 +0100 From: Peter Zijlstra To: Wanpeng Li Cc: "linux-kernel@vger.kernel.org" , kvm , Paolo Bonzini , Radim Kr??m???? , Wanpeng Li Subject: Re: [PATCH v5 2/4] KVM: X86: Add paravirt remote TLB flush Message-ID: <20171116083849.tvvxhu764uy5lryx@hirez.programming.kicks-ass.net> References: <1510567280-19376-1-git-send-email-wanpeng.li@hotmail.com> <1510567280-19376-3-git-send-email-wanpeng.li@hotmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 16, 2017 at 01:30:57PM +0800, Wanpeng Li wrote: > -static DEFINE_PER_CPU(cpumask_var_t, __pv_tlb_mask); > +static DEFINE_PER_CPU(cpumask_t, __pv_tlb_mask); NR_CPUS=512 is a fairly common distro setting, that means cpumask_t is 64 bytes. So for my 144 CPU system, that is 9216 bytes I'll never see again. Not nice :/