From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760175AbdKPQnf (ORCPT ); Thu, 16 Nov 2017 11:43:35 -0500 Received: from mail-it0-f66.google.com ([209.85.214.66]:37632 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936094AbdKPQnL (ORCPT ); Thu, 16 Nov 2017 11:43:11 -0500 X-Google-Smtp-Source: AGs4zMZ2F8zhsxDt0CsavbihhWffW5AwL3foF7TfFgA74T1sY9+IN+IZdtIZHN353YN1GrgBQhsSiw== Date: Thu, 16 Nov 2017 08:43:06 -0800 From: Sami Tolvanen To: Will Deacon Cc: Alex Matveev , Andi Kleen , Ard Biesheuvel , Greg Hackmann , Kees Cook , linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Rutland , Masahiro Yamada , Maxim Kuvyrkov , Michal Marek , Nick Desaulniers , Yury Norov , Matthias Kaehlcke Subject: Re: [PATCH v2 11/18] arm64: make mrs_s and msr_s macros work with LTO Message-ID: <20171116164306.GF94341@samitolvanen.mtv.corp.google.com> References: <20171115213428.22559-1-samitolvanen@google.com> <20171115213428.22559-12-samitolvanen@google.com> <20171116115433.GG9361@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171116115433.GG9361@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 16, 2017 at 11:54:33AM +0000, Will Deacon wrote: > What limitations? Can you elaborate please? Is this a fix? The commit message in v1 was more informative, I'll change this back for v3: -- Clang's integrated assembler does not allow assembly macros defined in one inline asm block using the .macro directive to be used across separate asm blocks. LLVM developers consider this a feature and not a bug, recommending code refactoring: https://bugs.llvm.org/show_bug.cgi?id=19749 As binutils doesn't allow macros to be redefined, this change adds C preprocessor macros that define the assembly macros globally for binutils and locally for clang's integrated assembler. Sami