From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932539AbdKQLpH (ORCPT <rfc822;w@1wt.eu>);
        Fri, 17 Nov 2017 06:45:07 -0500
Received: from mx2.suse.de ([195.135.220.15]:33573 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932416AbdKQLo5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 17 Nov 2017 06:44:57 -0500
Date: Fri, 17 Nov 2017 12:44:45 +0100
From: Borislav Petkov <bp@suse.de>
To: "Natarajan, Janakarajan" <Janakarajan.Natarajan@amd.com>,
        Paolo Bonzini <pbonzini@redhat.com>, Radim Krcmar <rkrcmar@redhat.com>
Cc: kvm@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H . Peter Anvin" <hpa@zytor.com>, Len Brown <len.brown@intel.com>,
        Kyle Huey <me@kylehuey.com>, Kan Liang <Kan.liang@intel.com>,
        Grzegorz Andrejczuk <grzegorz.andrejczuk@intel.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH v2 3/4] Add support for AMD Core Perf Extension in guest
Message-ID: <20171117114445.iv2s7sm2mjqusztx@pd.tnic>
References: <cover.1509985085.git.Janakarajan.Natarajan@amd.com>
 <5113a9d6e76d2c6050c1fba4007068340321521c.1509985085.git.Janakarajan.Natarajan@amd.com>
 <20171109183425.rhqc5wrltznt5tcf@pd.tnic>
 <07f23e5e-2747-b0bc-1b93-f83f3982649a@amd.com>
 <20171115190755.5n2zskcr2d4bmewp@pd.tnic>
 <c94fbc32-307f-01b9-564d-cfc68c94648a@amd.com>
 <20171116172520.4lgdvpcdxuxenxc7@pd.tnic>
 <2c785f9f-faac-58d5-2efd-3fce80d24c18@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2c785f9f-faac-58d5-2efd-3fce80d24c18@amd.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 16, 2017 at 12:00:11PM -0600, Natarajan, Janakarajan wrote:
> Ah my apologies. So when the pmu is initialized the cpuid entries
> aren't available then.

So let's see:

... kvm_arch_vcpu_create() ->
svm_create_vcpu() ->
kvm_vcpu_init() ->
kvm_arch_vcpu_init() ->

<--- HERE

kvm_pmu_init()

But at HERE in kvm_arch_vcpu_init() right before kvm_pmu_init() we do already query
cpuid:

	vcpu->arch.maxphyaddr = cpuid_query_maxphyaddr(vcpu);

so it's not like we don't know about cpuid leafs at that point. Which
would mean that the code can be made to set the CPU family earlier,
before kvm_pmu_init() runs so that you have the proper CPU family and
thus have this thing properly designed.

Maybe Paolo and Radim have a better suggestion here...

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--