From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755925AbdKQMf0 (ORCPT ); Fri, 17 Nov 2017 07:35:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:55148 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755302AbdKQMfU (ORCPT ); Fri, 17 Nov 2017 07:35:20 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA93C214EE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=sre@kernel.org Date: Fri, 17 Nov 2017 13:35:17 +0100 From: Sebastian Reichel To: Arvind Yadav Cc: kishon@ti.com, tony@atomide.com, robh@kernel.org, dan.carpenter@oracle.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] phy: cpcap-usb: Fix platform_get_irq_byname's error checking. Message-ID: <20171117123517.jjdia6dwccta5ojp@earth> References: <115b1328cd921849e8a3dd1832c21a3de59aa0e0.1510917723.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vrfecodedtotbi7k" Content-Disposition: inline In-Reply-To: <115b1328cd921849e8a3dd1832c21a3de59aa0e0.1510917723.git.arvind.yadav.cs@gmail.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --vrfecodedtotbi7k Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Nov 17, 2017 at 04:55:35PM +0530, Arvind Yadav wrote: > The platform_get_irq_byname() function returns negative if an error occur= s. > zero or positive number on success. platform_get_irq_byname() error > checking for zero is not correct. >=20 > Signed-off-by: Arvind Yadav > --- Fixes: 6d6ce40f63af ("phy: cpcap-usb: Add CPCAP PMIC USB support") Reviewed-by: Sebastian Reichel -- Sebastian > changes in v1 :=20 > Patch description was not correct. > =20 > drivers/phy/motorola/phy-cpcap-usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/phy/motorola/phy-cpcap-usb.c b/drivers/phy/motorola/= phy-cpcap-usb.c > index accaaac..6601ad0 100644 > --- a/drivers/phy/motorola/phy-cpcap-usb.c > +++ b/drivers/phy/motorola/phy-cpcap-usb.c > @@ -310,7 +310,7 @@ static int cpcap_usb_init_irq(struct platform_device = *pdev, > int irq, error; > =20 > irq =3D platform_get_irq_byname(pdev, name); > - if (!irq) > + if (irq < 0) > return -ENODEV; > =20 > error =3D devm_request_threaded_irq(ddata->dev, irq, NULL, > --=20 > 2.7.4 >=20 --vrfecodedtotbi7k Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAloO14IACgkQ2O7X88g7 +pqIfw/9G+rwI5Tj7z3MfXP4RVEwHc1hkwXbmqasltN/LSLmH1DtkxQPLIfEA7RP wbfuiWxrk4cuMjvTrC7mQU4kVgHE5al9pp/lpQTK75T23Uv8cPxxeXXSyUX8Z4nh RK1BTbHfUtbDngN+wbMvYmzyJ2ftov598ZXrbkEJo7SXGQOloTugO2JNjTKlRNJM K9ZM+kU+EXrfhUWkGDjGoD/RLpGcTWCbSPAUva/cEIuBajCLBCwXE3WBXIBLFq35 o3TjVlI8lqZgtVp+fKSlqs0jwKk9rfFyg7bdNivTujaIoEUaQ06VFXyIhLRfjbzz rnYkEvnvBO/ORcwF00lUHK5AmqjJ9gIu4vIa4Y7UOQa27ZAoXwysQJByS8/lFaeJ TD8UG8UldPwhryXmXgF4Ef/uRjl4LnyMcUTiB2RjQYNbrrR5fH7+j4b5s3TXgStp VDgToSm6mlkQu9e1zObHOUFrtC7UoBeM9FoljyNfrj4qigD5x9AKSFq2aSvq76ER npY89t0avCoxuS36P4WytdxF+1xiXf00DAjuNws7U0FNuYd2QaNTVc0Ay9TGPs4H ftNkAQFcPUDsE7Y4AwXK128DME+Mg4iPOY7vjmGz0/VBgY6YhuOgGkUMKmEeT+VG 5301yqd1efuYiK/HHEvAitcn7Fe70AzZxkDiGnXrR21WE4Agvvo= =aSHy -----END PGP SIGNATURE----- --vrfecodedtotbi7k--