From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758031AbdKQU2A (ORCPT ); Fri, 17 Nov 2017 15:28:00 -0500 Received: from mail-it0-f67.google.com ([209.85.214.67]:37449 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161872AbdKQU1G (ORCPT ); Fri, 17 Nov 2017 15:27:06 -0500 X-Google-Smtp-Source: AGs4zMYdpdKmWb0NKPdirGzDTpLo7otSd6oX3LtdNVF/u+chrYMC7fZYva4XZY1+VbH9Sd84amgk9g== Date: Fri, 17 Nov 2017 12:27:02 -0800 From: Dmitry Torokhov To: Arvind Yadav Cc: maxime.ripard@free-electrons.com, wens@csie.org, linux@roeck-us.net, wsa@the-dreams.de, daniel.thompson@linaro.org, mcuos.com@gmail.com, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 03/10] Input: twl4030_keypad: Fix platform_get_irq's error checking Message-ID: <20171117202702.nzfptx5qdcujh4al@dtor-ws> References: <1510946132-13554-1-git-send-email-arvind.yadav.cs@gmail.com> <1510946132-13554-4-git-send-email-arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1510946132-13554-4-git-send-email-arvind.yadav.cs@gmail.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 18, 2017 at 12:45:25AM +0530, Arvind Yadav wrote: > The platform_get_irq() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq() error checking > for zero is not correct. > > Signed-off-by: Arvind Yadav > --- > drivers/input/keyboard/twl4030_keypad.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/twl4030_keypad.c b/drivers/input/keyboard/twl4030_keypad.c > index f9f98ef..f94090e 100644 > --- a/drivers/input/keyboard/twl4030_keypad.c > +++ b/drivers/input/keyboard/twl4030_keypad.c > @@ -389,7 +389,7 @@ static int twl4030_kp_probe(struct platform_device *pdev) > } > > kp->irq = platform_get_irq(pdev, 0); > - if (!kp->irq) { > + if (kp->irq < 0) { kp->irq is unsigned > dev_err(&pdev->dev, "no keyboard irq assigned\n"); > return -EINVAL; Let's not clobber error. > } > -- > 2.7.4 > -- Dmitry