From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: lee.jones@linaro.org, maxime.ripard@free-electrons.com,
wens@csie.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/3] mfd: Handle platform_get_irq's error checking and return
Date: Sat, 18 Nov 2017 08:15:40 +0000 [thread overview]
Message-ID: <20171118081540.GQ31757@n2100.armlinux.org.uk> (raw)
In-Reply-To: <1510986993-4936-1-git-send-email-arvind.yadav.cs@gmail.com>
On Sat, Nov 18, 2017 at 12:06:30PM +0530, Arvind Yadav wrote:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct and we must check its return value.
The failure case is <= 0, not < 0. IRQ0 is not valid. Please rework
your patches to that effect, thanks.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
prev parent reply other threads:[~2017-11-18 8:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-18 6:36 Arvind Yadav
2017-11-18 6:36 ` [PATCH 1/3] mfd: ipaq-micro: Fix platform_get_irq's error checking Arvind Yadav
2017-11-18 6:36 ` [PATCH 2/3] mfd: intel-lpss: Handle return value of platform_get_* Arvind Yadav
2017-11-18 6:36 ` [PATCH 3/3] mfd: sun4i-gpadc: Handle return value of platform_get_irq Arvind Yadav
2017-11-18 8:15 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171118081540.GQ31757@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=arvind.yadav.cs@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®