From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946138AbdKRIWU (ORCPT ); Sat, 18 Nov 2017 03:22:20 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:49290 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946110AbdKRIVh (ORCPT ); Sat, 18 Nov 2017 03:21:37 -0500 Date: Sat, 18 Nov 2017 08:21:22 +0000 From: Russell King - ARM Linux To: Arvind Yadav Cc: dmitry.torokhov@gmail.com, maxime.ripard@free-electrons.com, wens@csie.org, linux@roeck-us.net, wsa@the-dreams.de, daniel.thompson@linaro.org, mcuos.com@gmail.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: Re: [PATCH 5/10 v2] Input: cpcap-pwrbutton: Handle return value of platform_get_irq Message-ID: <20171118082122.GB31757@n2100.armlinux.org.uk> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 18, 2017 at 02:36:53AM +0530, Arvind Yadav wrote: > platform_get_irq() can fail here and we must check its return value. The test should be <= 0, and you need to return an error code for the 0 case. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up