From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751010AbdKSIjf (ORCPT ); Sun, 19 Nov 2017 03:39:35 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:53919 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750882AbdKSIje (ORCPT ); Sun, 19 Nov 2017 03:39:34 -0500 Date: Sun, 19 Nov 2017 09:39:32 +0100 From: Alexandre Belloni To: Arvind Yadav Cc: arnd@arndb.de, gregkh@linuxfoundation.org, joel@jms.id.au, nicolas.ferre@microchip.com, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2 v3] misc: atmel-ssc: Fix platform_get_irq's error checking Message-ID: <20171119083932.7qm2dnqqsgrzbim7@piout.net> References: <3ce95a4e4eb4476b19868f36cd1f11e4b62b6203.1511065797.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/11/2017 at 10:04:01 +0530, Arvind Yadav wrote: > The platform_get_irq() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq() error checking > for zero is not correct. > > Signed-off-by: Arvind Yadav > --- > changes in v2 : > Add failure case '<= 0' instead of '< 0'. IRQ 0 is not valid. > changes in v3: > Return -ENODEV instead of ssc->irq. The patch is not doing what you claim here. > > drivers/misc/atmel-ssc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c > index b2a0340..2ec0f9e 100644 > --- a/drivers/misc/atmel-ssc.c > +++ b/drivers/misc/atmel-ssc.c > @@ -235,7 +235,7 @@ static int ssc_probe(struct platform_device *pdev) > clk_disable_unprepare(ssc->clk); > > ssc->irq = platform_get_irq(pdev, 0); > - if (!ssc->irq) { > + if (ssc->irq <= 0) { > dev_dbg(&pdev->dev, "could not get irq\n"); > return -ENXIO; > } > -- > 2.7.4 > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com