From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751159AbdKSUCT (ORCPT ); Sun, 19 Nov 2017 15:02:19 -0500 Received: from mail-qk0-f193.google.com ([209.85.220.193]:46749 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952AbdKSUCR (ORCPT ); Sun, 19 Nov 2017 15:02:17 -0500 X-Google-Smtp-Source: AGs4zMaQKuc5v6nS5gYs2wj0xGgI0xWqfO0BZqW2wBhVRWrhlxZrDr/alh0TymugnNeGHbjW21XaOA== Date: Sun, 19 Nov 2017 15:02:10 -0500 From: Tim Hansen To: viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, devtimhansen@gmail.com Subject: [PATCH] fs: Safe rcu access to hlist. Message-ID: <20171119200210.hhrklgm6hxhoyhqh@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adds hlist_first_rcu and hlist_next_rcu for safe access to the hlist in seq_hlist_next_rcu. Found on linux-next branch, tag next-20171117 with sparse. Signed-off-by: Tim Hansen --- fs/seq_file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/seq_file.c b/fs/seq_file.c index fb17f35a49a6..0b966781fd60 100644 --- a/fs/seq_file.c +++ b/fs/seq_file.c @@ -968,9 +968,9 @@ struct hlist_node *seq_hlist_next_rcu(void *v, ++*ppos; if (v == SEQ_START_TOKEN) - return rcu_dereference(head->first); + return rcu_dereference(hlist_first_rcu(head)); else - return rcu_dereference(node->next); + return rcu_dereference(hlist_next_rcu(node)); } EXPORT_SYMBOL(seq_hlist_next_rcu); -- 2.15.0.rc0