From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751121AbdKTFnp (ORCPT ); Mon, 20 Nov 2017 00:43:45 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:39866 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750934AbdKTFnn (ORCPT ); Mon, 20 Nov 2017 00:43:43 -0500 X-Google-Smtp-Source: AGs4zMbwOgqadnBlHtkbjqTM1++omcfQCbCfRFU7WIkpkKM/VYj/v2gQwQF8fAxqmgtm/iDrr1I6yA== Date: Mon, 20 Nov 2017 11:13:40 +0530 From: Viresh Kumar To: Arvind Yadav Cc: ulf.hansson@linaro.org, carlo@caione.org, khilman@baylibre.com, ben-linux@fluff.org, adrian.hunter@intel.com, vireshk@kernel.org, maxime.ripard@free-electrons.com, wens@csie.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Subject: Re: [PATCH 4/6] mmc: sdhci-spear: Handle return value of platform_get_irq Message-ID: <20171120054340.GB6125@vireshk-i7> References: <1510950502-22565-1-git-send-email-arvind.yadav.cs@gmail.com> <1510950502-22565-5-git-send-email-arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1510950502-22565-5-git-send-email-arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18-11-17, 01:58, Arvind Yadav wrote: > platform_get_irq() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > drivers/mmc/host/sdhci-spear.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c > index 8c0f884..900838b 100644 > --- a/drivers/mmc/host/sdhci-spear.c > +++ b/drivers/mmc/host/sdhci-spear.c > @@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev) > host->hw_name = "sdhci"; > host->ops = &sdhci_pltfm_ops; > host->irq = platform_get_irq(pdev, 0); > + if (host->irq < 0) { > + ret = host->irq; > + goto err_host; > + } > host->quirks = SDHCI_QUIRK_BROKEN_ADMA; > > sdhci = sdhci_priv(host); Acked-by: Viresh Kumar -- viresh