From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751275AbdKTGpR (ORCPT ); Mon, 20 Nov 2017 01:45:17 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:43363 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751213AbdKTGpQ (ORCPT ); Mon, 20 Nov 2017 01:45:16 -0500 X-Google-Smtp-Source: AGs4zMZgTlfbdnwaJp3uvUr5exjNRaXh/rxT6tv6d90ZzYRXTRWIYSCwh5rrsGNSEQJQUVk0vz9N+g== Date: Mon, 20 Nov 2017 12:15:13 +0530 From: Viresh Kumar To: Arvind Yadav Cc: ben-linux@fluff.org, ulf.hansson@linaro.org, adrian.hunter@intel.com, vireshk@kernel.org, maxime.ripard@free-electrons.com, wens@csie.org, linux@armlinux.org.uk, carlo@caione.org, khilman@baylibre.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org Subject: Re: [PATCH 4/6 v3] mmc: sdhci-spear: Handle return value of platform_get_irq Message-ID: <20171120064513.GE6125@vireshk-i7> References: <23382b551ade00543aadc588aa74b0648958b907.1511066652.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <23382b551ade00543aadc588aa74b0648958b907.1511066652.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19-11-17, 10:22, Arvind Yadav wrote: > platform_get_irq() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > changes in v2 : > Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid. > changes in v3 : > return -EINVAL instead of host->irq. > > drivers/mmc/host/sdhci-spear.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c > index 8c0f884..e04485e 100644 > --- a/drivers/mmc/host/sdhci-spear.c > +++ b/drivers/mmc/host/sdhci-spear.c > @@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev) > host->hw_name = "sdhci"; > host->ops = &sdhci_pltfm_ops; > host->irq = platform_get_irq(pdev, 0); > + if (host->irq <= 0) { > + ret = -EINVAL; > + goto err_host; > + } > host->quirks = SDHCI_QUIRK_BROKEN_ADMA; > > sdhci = sdhci_priv(host); Hope this is the last one to Ack :) Acked-by: Viresh Kumar -- viresh