From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751152AbdKTL50 (ORCPT ); Mon, 20 Nov 2017 06:57:26 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:32954 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751061AbdKTL5Y (ORCPT ); Mon, 20 Nov 2017 06:57:24 -0500 Date: Mon, 20 Nov 2017 12:57:14 +0100 From: Peter Zijlstra To: Megha Dey Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, andriy.shevchenko@linux.intel.com, kstewart@linuxfoundation.org, yu-cheng.yu@intel.com, len.brown@intel.com, gregkh@linuxfoundation.org, acme@kernel.org, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, vikas.shivappa@linux.intel.com, pombredanne@nexb.com, me@kylehuey.com, bp@suse.de, grzegorz.andrejczuk@intel.com, tony.luck@intel.com, corbet@lwn.net, ravi.v.shankar@intel.com, megha.dey@intel.com Subject: Re: [PATCH V2 2/3] perf/x86/intel/bm.c: Add Intel Branch Monitoring support Message-ID: <20171120115714.hden247iet4bf2t5@hirez.programming.kicks-ass.net> References: <1510970046-25387-1-git-send-email-megha.dey@linux.intel.com> <1510970046-25387-3-git-send-email-megha.dey@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1510970046-25387-3-git-send-email-megha.dey@linux.intel.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 17, 2017 at 05:54:05PM -0800, Megha Dey wrote: > + mutex_lock(&bm_counter_mutex); > + for (i = 0; i < BM_MAX_COUNTERS; i++) { > + if (bm_counter_owner[i] == NULL) { > + counter_to_use = i; > + bm_counter_owner[i] = event; > + break; > + } > + } > + mutex_unlock(&bm_counter_mutex); > + > + if (counter_to_use == -1) > + return -EBUSY; > +static struct pmu intel_bm_pmu = { > + .task_ctx_nr = perf_sw_context, > + .attr_groups = intel_bm_attr_groups, > + .event_init = intel_bm_event_init, > + .add = intel_bm_event_add, > + .del = intel_bm_event_del, > +}; Still horrid.. still no.