From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751451AbdKTNh3 (ORCPT ); Mon, 20 Nov 2017 08:37:29 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:37898 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbdKTNh2 (ORCPT ); Mon, 20 Nov 2017 08:37:28 -0500 Date: Mon, 20 Nov 2017 14:37:17 +0100 From: Alexandre Belloni To: Arvind Yadav Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux@armlinux.org.uk, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH 1/5 v4] ASoC: ep93xx-ac97: Fix platform_get_irq's error checking Message-ID: <20171120133717.kscrjsb3y7gnvd2t@piout.net> References: <082d4479211d425219f4ab275ecc12e1011eca2f.1511062844.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <082d4479211d425219f4ab275ecc12e1011eca2f.1511062844.git.arvind.yadav.cs@gmail.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/11/2017 at 09:45:00 +0530, Arvind Yadav wrote: > The platform_get_irq() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq() error checking > for zero is not correct. > > Signed-off-by: Arvind Yadav > --- > changes in v2 : > irq was unsigned. so changed it to signed. > changes in v3 : > Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid. > changes in v4 : > Return -ENODEV insted of irq. > To ensure this doesn't get applied: platform_get_irq can return -EPROBE_DEFER and this must be handled properly. (Or maybe this has never caused anything and never failed at all and nobody cares). > sound/soc/cirrus/ep93xx-ac97.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/cirrus/ep93xx-ac97.c b/sound/soc/cirrus/ep93xx-ac97.c > index bbf7a92..efeecee 100644 > --- a/sound/soc/cirrus/ep93xx-ac97.c > +++ b/sound/soc/cirrus/ep93xx-ac97.c > @@ -365,7 +365,7 @@ static int ep93xx_ac97_probe(struct platform_device *pdev) > { > struct ep93xx_ac97_info *info; > struct resource *res; > - unsigned int irq; > + int irq; > int ret; > > info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL); > @@ -378,7 +378,7 @@ static int ep93xx_ac97_probe(struct platform_device *pdev) > return PTR_ERR(info->regs); > > irq = platform_get_irq(pdev, 0); > - if (!irq) > + if (irq <= 0) > return -ENODEV; > > ret = devm_request_irq(&pdev->dev, irq, ep93xx_ac97_interrupt, > -- > 2.7.4 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com