From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751152AbdKTEce (ORCPT ); Sun, 19 Nov 2017 23:32:34 -0500 Received: from ozlabs.org ([103.22.144.67]:37767 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750969AbdKTEcc (ORCPT ); Sun, 19 Nov 2017 23:32:32 -0500 Date: Mon, 20 Nov 2017 15:32:30 +1100 From: Stephen Rothwell To: Dan Williams Cc: Andrew Morton , Linux-Next Mailing List , Linux Kernel Mailing List Subject: Re: linux-next: build failure after merge of the akpm-current tree Message-ID: <20171120153230.1738cc35@canb.auug.org.au> In-Reply-To: References: <20171120125748.156fa18b@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dan, On Sun, 19 Nov 2017 20:25:18 -0800 Dan Williams wrote: > > Ugh, yes. Looks correct. I might have confused my build success > notifications from 0day. I'll spin out a new branch to make sure this > is the last of it. Thanks. While I have your attention ... did you consider using the other paradigm: In arch include files: #define pud_write pud_write static inline int pud_write(pud_t pud) ..... Then in include/asm-generic/pgtable.h: #ifndef pud_write tatic inline int pud_write(pud_t pud) { .... } #endif If you had, then the powerpc code would have worked ... ;-) and many of the other interfaces in include/asm-generic/pgtable.h are protected that way ... -- Cheers, Stephen Rothwell