From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751859AbdKTXqv (ORCPT <rfc822;w@1wt.eu>);
        Mon, 20 Nov 2017 18:46:51 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:52108 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751305AbdKTXqu (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 20 Nov 2017 18:46:50 -0500
Date: Mon, 20 Nov 2017 15:46:48 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: srividya.dr@samsung.com
Cc: "sjenning@redhat.com" <sjenning@redhat.com>,
        "ddstreet@ieee.org" <ddstreet@ieee.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "penberg@kernel.org" <penberg@kernel.org>,
        Dinakar Reddy Pathireddy <dinakar.p@samsung.com>,
        SHARAN ALLUR <sharan.allur@samsung.com>,
        RAJIB BASU <rajib.basu@samsung.com>, JUHUN KIM <juhunkim@samsung.com>,
        "srividya.desireddy@gmail.com" <srividya.desireddy@gmail.com>
Subject: Re: [PATCH] zswap: Same-filled pages handling
Message-Id: <20171120154648.6c2f96804c4c1668bd8d572a@linux-foundation.org>
In-Reply-To: <20171018104832epcms5p1b2232e2236258de3d03d1344dde9fce0@epcms5p1>
References: <CGME20171018104832epcms5p1b2232e2236258de3d03d1344dde9fce0@epcms5p1>
        <20171018104832epcms5p1b2232e2236258de3d03d1344dde9fce0@epcms5p1>
X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 18 Oct 2017 10:48:32 +0000 Srividya Desireddy <srividya.dr@samsung.com> wrote:

> +/* Enable/disable handling same-value filled pages (enabled by default) */
> +static bool zswap_same_filled_pages_enabled = true;
> +module_param_named(same_filled_pages_enabled, zswap_same_filled_pages_enabled,
> +		   bool, 0644);

Do we actually need this?  Being able to disable the new feature shows
a certain lack of confidence ;) I guess we can remove it later as that
confidence grows.

Please send a patch to document this parameter in
Documentation/vm/zswap.txt.  And if you have time, please check that
the rest of that file is up-to-date?

Thanks.