From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752670AbdKTUIh (ORCPT ); Mon, 20 Nov 2017 15:08:37 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:40082 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752562AbdKTUIf (ORCPT ); Mon, 20 Nov 2017 15:08:35 -0500 X-Google-Smtp-Source: AGs4zMbJftC86R9fZ6qDgH78cngn5UjhsDfkmmGLqapiefEuob41kAmrejOVYouUyEkqMgMGMBnyZA== Date: Mon, 20 Nov 2017 21:08:31 +0100 From: Luc Van Oostenryck To: Jim Davis Cc: Masahiro Yamada , Knut Omang , Linux Kernel Mailing List , Michal Marek , Linux Kbuild mailing list Subject: Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch Message-ID: <20171120200827.726yhebihjhrhted@ltop.local> References: <716fa938a4ab0ad66490b72e2ed750cd6583728f.1510840787.git-series.knut.omang@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 20, 2017 at 12:48:35PM -0700, Jim Davis wrote: > > I'd be nice if people could just specify CHECK and CHECKFLAGS to run > their favorite checker, but currently CHECKFLAGS seems hardwired for > running sparse. So something liike > > make C=1 CHECK="scripts/checkpatch.pl" CHECKFLAGS="--quiet --file" > > fails when checkpatch is passed lots of arguments like -D__linux__ > -Dlinux -D__STDC__ . A little shell wrapper to grab the last argument > in that long list is a workaround, but perhaps CHECKFLAGS should be > made less sparse-specific? It should be noted though that CHECKFLAGS contains very very few sparse specific things. It's mainly flags for the compiler coming from KBUILD_CFLAGS (which of course, sparse needs to do its job properly). -- Luc Van Oostenryck