From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751887AbdKTWEF (ORCPT ); Mon, 20 Nov 2017 17:04:05 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36020 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221AbdKTWED (ORCPT ); Mon, 20 Nov 2017 17:04:03 -0500 X-Google-Smtp-Source: AGs4zMZN789UPJwWYEODDfkgYZa9VqHD6K8y663Wvm4nWJn8b7mLBCvYw8J0AOwQxL+kdZkagyLZAw== Date: Mon, 20 Nov 2017 22:03:59 +0000 From: Alex Matveev To: Ard Biesheuvel Cc: Mark Rutland , Sami Tolvanen , Andi Kleen , Greg Hackmann , Kees Cook , "linux-arm-kernel@lists.infradead.org" , linux-kbuild@vger.kernel.org, "linux-kernel@vger.kernel.org" , Masahiro Yamada , Maxim Kuvyrkov , Michal Marek , Nick Desaulniers , Yury Norov , Matthias Kaehlcke Subject: Re: [PATCH v2 16/18] arm64: crypto: disable LTO for aes-ce-cipher.c Message-ID: <20171120220359.1dcc885a@delmar.localdomain> In-Reply-To: References: <20171115213428.22559-1-samitolvanen@google.com> <20171115213428.22559-17-samitolvanen@google.com> <20171120152014.hftuded4zxwn2r7m@lakrids.cambridge.arm.com> <20171120212941.051d11c4@delmar.localdomain> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vAKM4CJH029366 Sami, this seems to be better solution for aes-ce-cipher.c problem. Regards, Alex >>From 6bcdd763b56ce10a77a79373a46fc0e8d9026178 Mon Sep 17 00:00:00 2001 From: Alex Matveev Date: Mon, 20 Nov 2017 21:30:38 +0000 Subject: [PATCH] arm64: crypto: fix typo in aes_sub() Clang's integrated assembler can't parse "v0.4s[0]" argument of the UMOV instruction. And, as per ARM ARM, this is incorrect usage: UMOV , .[] ... For the 32-bit variant: is an element size specifier, encoded in the "imm5" field. It can have the following values: B when imm5 = xxxx1 H when imm5 = xxx10 S when imm5 = xx100 Signed-off-by: Alex Matveev --- arch/arm64/crypto/aes-ce-cipher.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/crypto/aes-ce-cipher.c b/arch/arm64/crypto/aes-ce-cipher.c index 6a75cd75ed11..e26bedee2c45 100644 --- a/arch/arm64/crypto/aes-ce-cipher.c +++ b/arch/arm64/crypto/aes-ce-cipher.c @@ -152,7 +152,7 @@ static u32 aes_sub(u32 input) __asm__("dup v1.4s, %w[in] ;" "movi v0.16b, #0 ;" "aese v0.16b, v1.16b ;" - "umov %w[out], v0.4s[0] ;" + "umov %w[out], v0.s[0] ;" : [out] "=r"(ret) : [in] "r"(input) -- 2.15.0