From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751760AbdKTXnp (ORCPT ); Mon, 20 Nov 2017 18:43:45 -0500 Received: from mga03.intel.com ([134.134.136.65]:29004 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751299AbdKTXno (ORCPT ); Mon, 20 Nov 2017 18:43:44 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,430,1505804400"; d="scan'208";a="175931307" Date: Tue, 21 Nov 2017 01:43:40 +0200 From: Jarkko Sakkinen To: Thomas Gleixner Cc: Peter Zijlstra , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 08/11] intel_sgx: in-kernel launch enclave Message-ID: <20171120234340.tnatm3qz5nrnjtmi@linux.intel.com> References: <20171113194528.28557-1-jarkko.sakkinen@linux.intel.com> <20171113194528.28557-9-jarkko.sakkinen@linux.intel.com> <20171115115006.p2wkvfuojwgg26br@hirez.programming.kicks-ass.net> <20171120222535.7yqibz2rxltwvip7@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 20, 2017 at 11:43:22PM +0100, Thomas Gleixner wrote: > On Tue, 21 Nov 2017, Jarkko Sakkinen wrote: > > On Wed, Nov 15, 2017 at 12:50:06PM +0100, Peter Zijlstra wrote: > > > On Mon, Nov 13, 2017 at 09:45:25PM +0200, Jarkko Sakkinen wrote: > > > > TinyCrypt (https://github.com/01org/tinycrypt) is used as AES > > > > implementation, which is not timing resistant. Eventually this needs to > > > > be replaced with AES-NI based implementation that could be either > > > > > > > - re-use existing AES-NI code in the kernel > > > > > > This. That is an absolute must. We're not going to merge custom AES > > > implementations. > > > > I'll post v6 update without update to this in order to get otherwise > > improved version out and work on it for v7. > > > > My initial idea to sort this out would be to try to compile > > > > arch/x86/crypto/aesni-intel_asm.S > > > > as part of the enclave binary and use it to run AES-256. > > No. The kernel has a crypto API. But you cannot call it from inside an enclave. A syscall will exit the enclave. The launch enclave requires AES-256 to be executed inside the enclave. /Jarkko