From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] perf intel-pt: Improve build messages for files that differ from the kernel
Date: Tue, 21 Nov 2017 10:30:33 -0300 [thread overview]
Message-ID: <20171121133033.GI7918@kernel.org> (raw)
In-Reply-To: <20171121084111.y6p5zwqso2cbms5s@gmail.com>
Em Tue, Nov 21, 2017 at 09:41:11AM +0100, Ingo Molnar escreveu:
> Also, I'd suggest removing this from check-headers.sh:
>
> opts="--ignore-blank-lines --ignore-space-change"
>
> as the easiest policy is to just follow the upstream UAPI header version 100%.
> Pure space-only changes are comparatively rare.
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
Thanks, applied.
- Arnaldo
>
> tools/perf/check-headers.sh | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
> index 77406d25e521..e66a8a7bcced 100755
> --- a/tools/perf/check-headers.sh
> +++ b/tools/perf/check-headers.sh
> @@ -45,7 +45,6 @@ include/uapi/asm-generic/mman-common.h
>
> check () {
> file=$1
> - opts="--ignore-blank-lines --ignore-space-change"
>
> shift
> while [ -n "$*" ]; do
next prev parent reply other threads:[~2017-11-21 13:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 8:35 [PATCH 0/2] perf intel-pt: Bring instruction decoder files into line with " Adrian Hunter
2017-11-21 8:35 ` [PATCH 1/2] perf intel-pt: Improve build messages for files that differ from " Adrian Hunter
2017-11-21 8:41 ` Ingo Molnar
2017-11-21 13:30 ` Arnaldo Carvalho de Melo [this message]
2017-11-23 18:41 ` Arnaldo Carvalho de Melo
2017-12-06 16:31 ` [tip:perf/core] tools headers: Follow the upstream UAPI header version 100% " tip-bot for Ingo Molnar
2017-12-06 16:33 ` [tip:perf/core] perf intel-pt: Improve build messages for files that " tip-bot for Adrian Hunter
2017-11-21 8:35 ` [PATCH 2/2] perf intel-pt: Bring instruction decoder files into line with " Adrian Hunter
2017-11-29 6:36 ` [tip:perf/core] " tip-bot for Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121133033.GI7918@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome