From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751502AbdKUSDE (ORCPT ); Tue, 21 Nov 2017 13:03:04 -0500 Received: from omzsmtpe03.verizonbusiness.com ([199.249.25.208]:19732 "EHLO omzsmtpe03.verizonbusiness.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751145AbdKUSDC (ORCPT ); Tue, 21 Nov 2017 13:03:02 -0500 From: alexander.levin@verizon.com X-Host: mariner.tdc.vzwcorp.com To: Josh Boyer CC: Emil Velikov , Greg KH , Jani Nikula , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , ML dri-devel Subject: Re: Autoselect patches for stable (Was: Re: [PATCH AUTOSEL for 4.9 36/56] drm/i915: Fix the level 0 max_wm hack on VLV/CHV) Thread-Topic: Autoselect patches for stable (Was: Re: [PATCH AUTOSEL for 4.9 36/56] drm/i915: Fix the level 0 max_wm hack on VLV/CHV) Thread-Index: AQHTYvLXZIH2PJuzvUu6oLdfCYEzlQ== Date: Tue, 21 Nov 2017 18:02:06 +0000 Message-ID: <20171121180204.i5b4w5ijbbigyxch@sasha-lappy> References: <20171121150728.7o5zvf7sog5yric3@sasha-lappy> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: NeoMutt/20170113 (1.7.2) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.144.60.250] Content-Type: text/plain; charset="us-ascii" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vALI39C8027450 On Tue, Nov 21, 2017 at 12:09:33PM -0500, Josh Boyer wrote: >The root of the concern seems to be around how the stable process >currently works and how auto-selection plays into that. When Greg >sends out the RC, the default model of "if nobody objects, this patch >will get included in the next stable release" works because a human >already identified as that needing to be included. So the review is >looking for a NAK, but that's overriding another human's explicit >decision with reasons. For something that is auto-selected, people >seem concerned that the default should be flipped. Perhaps they'd be >more comfortable if auto-selected packages required a human ACK before >they are included? Josh, I review the autogenerated list of commits, patch by patch, myself, before sending it out. So there is a human involved in the process. Admittingly I'm not perfect and things do slip by once in a while. I always look back and try to improve the process. Although the sample size is small now (~600 commits proposed and merged using this method) I don't belive the error rate is higher than the error rate for "regular" stable tree commits. I'd treat autoselection as a helper tool for the stable tree maintainer rather than a magical way to produce stable commits (we're not going to replace Greg with a robot any time soon). -- Thanks, Sasha