From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751415AbdKUSkS (ORCPT ); Tue, 21 Nov 2017 13:40:18 -0500 Received: from mail-it0-f44.google.com ([209.85.214.44]:34416 "EHLO mail-it0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751184AbdKUSkQ (ORCPT ); Tue, 21 Nov 2017 13:40:16 -0500 X-Google-Smtp-Source: AGs4zManIYdTyM9bb5IhNBEkV19CpOFt3Mp57KUkKLFNaYMkAVMnBq4xe5MJWSTer8I89jeYxTfdKA== Date: Tue, 21 Nov 2017 10:40:12 -0800 From: Eudean Sun To: Jiri Kosina Cc: Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: cp2112: Fix I2C_BLOCK_DATA transactions Message-ID: <20171121184012.GA6776@mail.arista.com> References: <20171114000358.GA14433@mail.arista.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 21, 2017 at 05:45:32PM +0100, Jiri Kosina wrote: > On Tue, 21 Nov 2017, Jiri Kosina wrote: > > > > The existing driver erroneously treats I2C_BLOCK_DATA and BLOCK_DATA > > > commands the same. Fix the logic for I2C_BLOCK_DATA reads and writes. > > > > Addin David, the original author of the driver (and the code in question > > as well) to CC. > > Alright, that address bounces. > > In that case -- could you please be a little bit more specific in the > changelog? Namely: what are the observable effects of this bug (did you > find it by code inspection or have you seen it triggering) and why this is > a proper fix for that bug. Thanks for the feedback Jiri, I will send out a new patch shortly with more detail in the changelog.