From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751471AbdKUS7E (ORCPT ); Tue, 21 Nov 2017 13:59:04 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:41442 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317AbdKUS7C (ORCPT ); Tue, 21 Nov 2017 13:59:02 -0500 X-Google-Smtp-Source: AGs4zMar91YSOlb2M7iRfn1X2buFvEVFYhlM0krCWwodk9wtIinLxrPNXnq7GfbR04EqH4+StzE2Qw== Date: Tue, 21 Nov 2017 11:58:56 -0700 From: Jason Gunthorpe To: Guenter Roeck Cc: Jarkko Sakkinen , Peter Huewe , Andrey Pronin , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tpm: Add explicit chip->ops locking for sysfs attributes. Message-ID: <20171121185856.GG18272@ziepe.ca> References: <1510867501-9498-1-git-send-email-linux@roeck-us.net> <20171120221323.252ki4nmmrymnty6@linux.intel.com> <20171120224523.GA26294@roeck-us.net> <20171120231728.GR29075@ziepe.ca> <20171120234947.zd5bekvqg5z5rp3i@linux.intel.com> <20171121182858.GA4895@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171121182858.GA4895@roeck-us.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 21, 2017 at 10:28:58AM -0800, Guenter Roeck wrote: > I'll split the patch into two parts, and only add (hopefully) > non-controversial tpm2 attributes for now (which I think is durations > and timeouts). Or, in other words, I'll split the attributes into > two groups - one generic and one for tpm1. Ok. Please look at new attributes you wish to add for tpm2 and see if they meet the modern sysfs sensibility of one value per file, etc. Jason