From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751433AbdKVHEa convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Wed, 22 Nov 2017 02:04:30 -0500
Received: from mail-pg0-f65.google.com ([74.125.83.65]:34495 "EHLO
        mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751148AbdKVHE3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 22 Nov 2017 02:04:29 -0500
X-Google-Smtp-Source: AGs4zMYn3KtqfnZDUA1zdsU4/xki8WqxQvB38L68jlzxw7NXPSns5qeeuMhjKVT9h+KrRQgp/btz9w==
Date: Tue, 21 Nov 2017 23:04:27 -0800
From: Matthew Giassa <matthew@giassa.net>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: Jesse Chan <jc@linux.com>,
        H Hartley Sweeten <hsweeten@visionengravers.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: comedi: add missing
 MODULE_DESCRIPTION/LICENSE
Message-ID: <20171122070427.lk7w6kdpao2234rt@darkstar>
References: <20171120070254.34587-1-jc@linux.com>
 <20171120075019.68767-1-jc@linux.com>
 <dc2648b6-8dfc-afc9-8b11-e6e82b7ae125@mev.co.uk>
 <39b27702-cd33-2fbf-d57c-6f30fe7a28b3@mev.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8BIT
In-Reply-To: <39b27702-cd33-2fbf-d57c-6f30fe7a28b3@mev.co.uk>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Ian Abbott <abbotti@mev.co.uk> [2017-11-20 10:46:36 +0000]:

>On 20/11/17 10:29, Ian Abbott wrote:
>>On 20/11/17 07:50, Jesse Chan wrote:
>>>This change resolves a new compile-time warning
>>>when built as a loadable module:
>>>
>>>WARNING: modpost: missing MODULE_LICENSE() in 
>>>drivers/staging/comedi/drivers/ni_atmio.o
>>>see include/linux/module.h for more information
>>>
>>>This adds the license as "GPL", which matches the header of the file.
>>>
>>>MODULE_DESCRIPTION is also added.
>>>
>>>Signed-off-by: Jesse Chan <jc@linux.com>
>>>---
>>>  drivers/staging/comedi/drivers/ni_atmio.c | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>>diff --git a/drivers/staging/comedi/drivers/ni_atmio.c 
>>>b/drivers/staging/comedi/drivers/ni_atmio.c
>>>index 2d62a8c57332..b61d56367773 100644
>>>--- a/drivers/staging/comedi/drivers/ni_atmio.c
>>>+++ b/drivers/staging/comedi/drivers/ni_atmio.c
>>>@@ -361,3 +361,6 @@ static struct comedi_driver ni_atmio_driver = {
>>>      .detach        = ni_atmio_detach,
>>>  };
>>>  module_comedi_driver(ni_atmio_driver);
>>>+
>>>+MODULE_DESCRIPTION("Comedi low-level driver");
>>>+MODULE_LICENSE("GPL");
>>
>>Thanks!  I wonder how I managed to miss out this driver in commit 
>>3c323c01b6bd ("Staging: comedi: Add MODULE_LICENSE and similar to NI 
>>modules")?
>>
>>Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
>
>Despite my above comment, we should probably give precedence to 
>Matthew Giassa's patch for the same issue, since it was sent earlier.
>
>-- 
>-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
>-=(                          Web: http://www.mev.co.uk/  )=-

-- 

Thanks. Also, this one should probably include the MODULE_AUTHOR macro
as well.

Cheers!