From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751504AbdKVMw7 (ORCPT ); Wed, 22 Nov 2017 07:52:59 -0500 Received: from nivc-ms.auriga.com ([80.240.102.145]:12391 "EHLO nivc-ms.auriga.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751244AbdKVMw5 (ORCPT ); Wed, 22 Nov 2017 07:52:57 -0500 X-Greylist: delayed 902 seconds by postgrey-1.27 at vger.kernel.org; Wed, 22 Nov 2017 07:52:56 EST From: Aleksey Makarov To: CC: , "Goutham, Sunil" , Robert Richter , "Florian Westphal" , Aleksey Makarov , Sunil Goutham , Aleksey Makarov , Subject: [PATCH net] net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts Date: Wed, 22 Nov 2017 15:37:25 +0300 Message-ID: <20171122123727.23580-1-aleksey.makarov@auriga.com> X-Mailer: git-send-email 2.15.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [80.240.102.216] X-ClientProxiedBy: hq-ms.office.auriga.msk (82.97.202.32) To nivc-ms.office.auriga.msk (80.240.102.145) X-TM-AS-Product-Ver: SMEX-12.0.0.1220-8.100.1062-23482.000 X-TM-AS-Result: No--7.118000-8.000000-31 X-TM-AS-MatchedID: 709291-863828-704501-703788-700486-702898-712222-700270-1 88019-704421-702099-703491-711624-702131-121155-148004-148036-42000-42003-63 X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sunil Goutham This fixes a previous patch which missed some changes and due to which L3 checksum offload was getting enabled for IPv6 pkts. And HW is dropping these pkts as it assumes the pkt is IPv4 when IP csum offload is set in the SQ descriptor. Fixes: bbbb494fd005 ("net: thunderx: Enable TSO and checksum offloads for ipv6") Signed-off-by: Sunil Goutham Signed-off-by: Aleksey Makarov --- drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c b/drivers/net/ethernet/cavium/thunder/nicvf_queues.c index d4496e9afcdf..184d5bdbe7e0 100644 --- a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c +++ b/drivers/net/ethernet/cavium/thunder/nicvf_queues.c @@ -1355,10 +1355,11 @@ nicvf_sq_add_hdr_subdesc(struct nicvf *nic, struct snd_queue *sq, int qentry, /* Offload checksum calculation to HW */ if (skb->ip_summed == CHECKSUM_PARTIAL) { - hdr->csum_l3 = 1; /* Enable IP csum calculation */ hdr->l3_offset = skb_network_offset(skb); hdr->l4_offset = skb_transport_offset(skb); + /* Enable IP HDR csum calculation for V4 pkts */ + hdr->csum_l3 = (ip.v4->version == 4) ? 1 : 0; proto = (ip.v4->version == 4) ? ip.v4->protocol : ip.v6->nexthdr; -- 2.15.0