From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752028AbdKVTGy (ORCPT ); Wed, 22 Nov 2017 14:06:54 -0500 Received: from mx2.suse.de ([195.135.220.15]:41184 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751634AbdKVTGx (ORCPT ); Wed, 22 Nov 2017 14:06:53 -0500 Date: Wed, 22 Nov 2017 20:06:31 +0100 From: Borislav Petkov To: Andy Lutomirski Cc: X86 ML , "linux-kernel@vger.kernel.org" , Brian Gerst , Dave Hansen , Linus Torvalds , Josh Poimboeuf Subject: Re: [PATCH v2 07/18] x86/asm: Fix assumptions that the HW TSS is at the beginning of cpu_tss Message-ID: <20171122190631.jenszvvr2wvg2ijk@pd.tnic> References: <44dc3ba2975a6b15ec444db488a3b78a61d8936e.1511325444.git.luto@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <44dc3ba2975a6b15ec444db488a3b78a61d8936e.1511325444.git.luto@kernel.org> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 21, 2017 at 08:44:02PM -0800, Andy Lutomirski wrote: > I'm going to move SYSENTER_stack to the beginning of cpu_tss to help > detect overflow. Before this can happen, I need to fix several code > paths that hardcode assumptions about the old layout. Please formulate that commit message in passive-impersonal: "Fix hardcoded assumptions about ... before ..." > > Reviewed-by: Thomas Gleixner > Signed-off-by: Andy Lutomirski > --- > arch/x86/include/asm/desc.h | 2 +- > arch/x86/include/asm/processor.h | 4 ++-- > arch/x86/kernel/cpu/common.c | 8 ++++---- > arch/x86/kernel/doublefault.c | 36 +++++++++++++++++------------------- > arch/x86/power/cpu.c | 13 +++++++------ > 5 files changed, 31 insertions(+), 32 deletions(-) With that: Reviewed-by: Borislav Petkov -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --