From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752110AbdKWBVG (ORCPT ); Wed, 22 Nov 2017 20:21:06 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:51044 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751692AbdKWBVD (ORCPT ); Wed, 22 Nov 2017 20:21:03 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20171123012101epoutp013dd7a9e3c67620ade3f2ca003c3254af~5klkUqzvO3047830478epoutp018 X-AuditID: b6c32a39-e0fff700000010dd-ef-5a16227c6faa Mime-Version: 1.0 Subject: RE: Re: [PATCH 1/4] rk3399_dmc: Fix line continuation format Reply-To: myungjoo.ham@samsung.com From: MyungJoo Ham To: Joe Perches , Chanwoo Choi , Kyungmin Park CC: "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: <1511347280.6989.81.camel@perches.com> X-Drm-Type: N,general X-EPLocale: ko_KR.EUC-KR X-EPWebmail-Msg-Type: personal X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20171123012100epcms1p13f78950557de06dbbd65996c8b0645ee@epcms1p1> Date: Thu, 23 Nov 2017 01:21:00 +0000 X-CMS-MailID: 20171123012100epcms1p13f78950557de06dbbd65996c8b0645ee Content-Type: text/plain; charset="utf-8" X-MTR: 20171123012100epcms1p13f78950557de06dbbd65996c8b0645ee CMS-TYPE: 101P X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrFKsWRmVeSWpSXmKPExsWy7bCmnm6NkliUwaUtWhbXvzxntZh9/zGL xdmmN+wWl3fNYbP43HuE0YHV48uqa8wefVtWMXp83iQXwByVapORmpiSWqSQmpecn5KZl26r 5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDtFJJoSwxpxQoFJBYXKykb2dTlF9akqqQ kV9cYqsUbWhopGdoYK5nZGSkZ2Ica2VkClSSkJpx+aJowQvxirvLZrM2MPaIdzFyckgImEhc 7pnB2MXIxSEksINRYsr6KcxdjBwcvAKCEn93CIPUCAu4Shy5/5kVxBYSUJJouLmPGSKuL9Hx YBsjiM0moCuxdcNdFhBbRKBEYnHTKrB6ZoEqiT8rH7BB7OKVmNH+lAXClpbYvnwrWC+ngLHE kTlX2SHiohI3V7+FsiUk7ry+wARhy0lM+7qGGabm/bH5jBC2iETrvbNQcUGJBz93g/0iIdDK KHFnyzOoQZISSw40MUMkljFKLL78lB3CWc4o0b5kIxvIxxJA7+zc7gzSwCvgK9HZdQDsUhYB VYnDx+9AfeAicfL/a3aIz7Qlli18DQ4sZgFNifW79CFKbCWmzvjCAlHCJ/Huaw8rzPM75j2B ekZN4tDuJewTGFVmIYJ6FpKhsxCGLmBkXsUollpQnJueWmxYYKpXnJhbXJqXrpecn7uJEZzu tCx3MB4753OIUYCDUYmHd8Uc0Sgh1sSy4srcQ4wSHMxKIrzBC4BCvCmJlVWpRfnxRaU5qcWH GE2BfpvILCWanA9MxXkl8YYmlgYmZkbAFGdpaKgkziu6/lqEkEB6YklqdmpqQWoRTB8TB6dU A+PSrJU/n5lpXlq+vzjFR0TuQFdj8/XTMndElnK/Za7ibLe9bFAT+2JTQvOzY8fUnu+Ujb9e HmsoLmozV/eo9NQzSUwSnGwu0aVTcr/V9Yo6Pa39IXQt4Fxj/fW8o+6b1tpHxq5M8um8K2+l U8XwSuLKpIIJNY9Zw/caZWw6qP04Yqb+xRvWHUosxRmJhlrMRcWJAMQoD0aNAwAA DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171116152742epcas2p22b17887a4d7f2adcd3beb414988dbce3 X-RootMTR: 20171116152742epcas2p22b17887a4d7f2adcd3beb414988dbce3 References: <1511347280.6989.81.camel@perches.com> <7d659960e45f66894126fba9e2d54cf25ae1185b.1510845910.git.joe@perches.com> <5A150792.6050104@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vAN1LAT3021485 > On Wed, 2017-11-22 at 14:13 +0900, Chanwoo Choi wrote: > > On 2017년 11월 17일 00:27, Joe Perches wrote: > > > Line continuations with excess spacing causes unexpected output. > > > > > > Signed-off-by: Joe Perches > > > --- > > > drivers/devfreq/rk3399_dmc.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c > > > index 5dfbfa3cc878..0938c97d46f0 100644 > > > --- a/drivers/devfreq/rk3399_dmc.c > > > +++ b/drivers/devfreq/rk3399_dmc.c > > > @@ -146,8 +146,8 @@ static int rk3399_dmcfreq_target(struct device *dev, unsigned long *freq, > > > > > > /* If get the incorrect rate, set voltage to old value. */ > > > if (dmcfreq->rate != target_rate) { > > > - dev_err(dev, "Get wrong ddr frequency, Request frequency %lu,\ > > > - Current frequency %lu\n", target_rate, dmcfreq->rate); > > > + dev_err(dev, "Get wrong ddr frequency, Request frequency %lu, Current frequency %lu\n", > > > + target_rate, dmcfreq->rate); > > > > IMO, I don't like over 80 char in the one line. > > Fix it as you chose, but the code I proposed > is what is preferred by CodingStyle. > > The current code is unintentional. > > Right now there are 3 tabs between "Request frequency" > and "Current frequency" in the output. Chanwoo, this is not a simple coding style issue. I'm seeing these unintentional tabs as well. If you want to keep it 80 cols with strings (which is not mandatory for strings in double quotes), We'd better do: - dev_err(dev, "Get wrong ddr frequency, Request frequency %lu,\ - Current frequency %lu\n", target_rate, dmcfreq->rate); + dev_err(dev, "Get wrong ddr frequency, Request frequency %lu," + " Current frequency %lu\n", target_rate, dmcfreq->rate); Cheers, MyungJoo > > > > regulator_set_voltage(dmcfreq->vdd_center, dmcfreq->volt, > > > dmcfreq->volt); > > > goto out; > > > > > > > >