From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751845AbdKWG6d (ORCPT <rfc822;w@1wt.eu>);
        Thu, 23 Nov 2017 01:58:33 -0500
Received: from mail-wr0-f173.google.com ([209.85.128.173]:33335 "EHLO
        mail-wr0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750916AbdKWG6c (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 23 Nov 2017 01:58:32 -0500
X-Google-Smtp-Source: AGs4zMasI8hn+fB6bH5MxCFsBscvEnPhDIHmpqCQWNZU2jGRRvou1FeZBMEdgSbG3ZrBx75TelxIRg==
Date: Thu, 23 Nov 2017 07:58:28 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, X86 ML <x86@kernel.org>,
        Borislav Petkov <bpetkov@suse.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Brian Gerst <brgerst@gmail.com>, Dave Hansen <dave.hansen@intel.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH v2 00/18] Entry stack switching
Message-ID: <20171123065828.dfzqe5cxfzlc2bcf@gmail.com>
References: <cover.1511325444.git.luto@kernel.org>
 <20171122062257.ivp5fbcy2k4mlfdm@gmail.com>
 <CALCETrVvpNVzixzAubip8-=8v=gE+Z_0CyXX117dmdbeXozEVQ@mail.gmail.com>
 <20171123062117.bztoxdqd2iv7ipdn@gmail.com>
 <20171123064414.hg7etp7iiis54ira@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171123064414.hg7etp7iiis54ira@gmail.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Ingo Molnar <mingo@kernel.org> wrote:

> 
> * Ingo Molnar <mingo@kernel.org> wrote:
> 
> > > Anyway, I booted your config (more or less -- I munged it through
> > > virtme-configkernel --update first) with 17 vCPUs and it seems fine.
> > > Is the issue reliable enough to bisect?
> > 
> > Ok, it should be bisectable, will try to bisect it.
> 
> The latestest entry-stack code appears to be working fine though.
> 
> So one of the below fixes from yesterday appears to have done the trick.
> 
> I'll re-test today to make sure: maybe it's more sporadic than I thought, in one 
> of the bootups I got the do_IRQ warning only once, in half a day of uptime.

I re-tested and it all seems fine now. I suspect it got fixed by:

  ca37e57bbe0c: x86/entry/64: Add missing irqflags tracing to native_load_gs_index()

still it is weird, because I boot that system with latest -tip on a daily basis, 
and don't remember having seen that warning.

Do you have any theory for why the entry stack changes would uncover this bug?

Thanks,

	Ingo