From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752734AbdKWLwE (ORCPT ); Thu, 23 Nov 2017 06:52:04 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:18499 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751965AbdKWLwC (ORCPT ); Thu, 23 Nov 2017 06:52:02 -0500 Date: Thu, 23 Nov 2017 14:51:38 +0300 From: Dan Carpenter To: "Tobin C. Harding" Cc: Stefano Manni , devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Oleg Drokin , Andreas Dilger , lustre-devel@lists.lustre.org Subject: Re: [PATCH 0/4] staging: lustre: fixed some signedness warns from sparse Message-ID: <20171123115138.5nku6epnct35mmha@mwanda> References: <20171122193831.11801-1-stefano.manni@gmail.com> <20171123045926.GD12736@eros> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171123045926.GD12736@eros> User-Agent: NeoMutt/20170609 (1.8.3) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 23, 2017 at 03:59:26PM +1100, Tobin C. Harding wrote: > On Wed, Nov 22, 2017 at 08:38:27PM +0100, Stefano Manni wrote: > > Fixed some signedness warnings from sparse on lustre. > > > > Stefano Manni (4): > > staging: lustre: fixed signedness of some socklnd params > > staging: lustre: fixed signedness of llite > > staging: lustre: fixed signedness of lov > > staging: lustre: fixed signedness of obdclass > > You may like to use imperative mood for your git log brief descriptions > Stefano. > > s/fixed/fix/ > Someone once chewed me a second butt hole for not using the imperative mood so I know some people care intensely about this but I think so long as you can understand the description it's fine. I will never send a patch for that maintainer's subsystem again, btw, which is probably grateful for and now I can poop twice as fast so we're both winners. Especially in the 0/4 patch which is going to be discarded. Who cares? regards, dan carpenter