From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752946AbdKWOhC (ORCPT ); Thu, 23 Nov 2017 09:37:02 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:45669 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752787AbdKWOhA (ORCPT ); Thu, 23 Nov 2017 09:37:00 -0500 Date: Thu, 23 Nov 2017 06:36:57 -0800 From: Christoph Hellwig To: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau Cc: linux-kernel@vger.kernel.org, somlo@cmu.edu, xiaolong.ye@intel.com, qemu-devel@nongnu.org, mst@redhat.com, Andrew Morton , Baoquan He , Dave Young , Hari Bathini , Tony Luck , Vivek Goyal Subject: Re: [PATCH v8 4/5] crash: export paddr_vmcoreinfo_note() Message-ID: <20171123143657.GA19971@infradead.org> References: <20171123140206.3911-1-marcandre.lureau@redhat.com> <20171123140206.3911-5-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171123140206.3911-5-marcandre.lureau@redhat.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 23, 2017 at 03:02:05PM +0100, Marc-André Lureau wrote: > The following patch is going to use the symbol from the fw_cfg module, > to call the function and write the note location details in the > vmcoreinfo entry, so qemu can produce dumps with the vmcoreinfo note. Sounds like fw_cfg should be moved to be built in only instead of exporting such a symbol address.