From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752883AbdKWOmT (ORCPT ); Thu, 23 Nov 2017 09:42:19 -0500 Received: from nivc-ms.auriga.com ([80.240.102.145]:45702 "EHLO nivc-ms.auriga.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751976AbdKWOmS (ORCPT ); Thu, 23 Nov 2017 09:42:18 -0500 From: Aleksey Makarov To: CC: , "Goutham, Sunil" , Robert Richter , "Florian Westphal" , Eric Dumazet , "Aleksey Makarov" , Sunil Goutham , Aleksey Makarov , Subject: [PATCH net v2] net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts Date: Thu, 23 Nov 2017 17:41:56 +0300 Message-ID: <20171123144158.26111-1-aleksey.makarov@auriga.com> X-Mailer: git-send-email 2.15.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [80.240.102.216] X-ClientProxiedBy: hq-ms.office.auriga.msk (82.97.202.32) To nivc-ms.office.auriga.msk (80.240.102.145) X-TM-AS-Product-Ver: SMEX-12.0.0.1220-8.100.1062-23484.002 X-TM-AS-Result: No--2.703000-8.000000-31 X-TM-AS-MatchedID: 700839-704501-703788-700486-702898-712222-700270-139705-7 03523-188019-704421-702099-703491-711624-702131-148004-148036-42000-42003-63 X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sunil Goutham Don't offload IP header checksum to NIC. This fixes a previous patch which enabled checksum offloading for both IPv4 and IPv6 packets. So L3 checksum offload was getting enabled for IPv6 pkts. And HW is dropping these pkts as it assumes the pkt is IPv4 when IP csum offload is set in the SQ descriptor. Fixes: bbbb494fd005 ("net: thunderx: Enable TSO and checksum offloads for ipv6") Signed-off-by: Sunil Goutham Signed-off-by: Aleksey Makarov --- drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 1 - 1 file changed, 1 deletion(-) v2: - Don't enable checksum offloading both for IPv4 and IPv6 (Eric Dumazet) v1: https://lkml.kernel.org/r/20171122123727.23580-1-aleksey.makarov@auriga.com diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c b/drivers/net/ethernet/cavium/thunder/nicvf_queues.c index d4496e9afcdf..8b2c31e2a2b0 100644 --- a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c +++ b/drivers/net/ethernet/cavium/thunder/nicvf_queues.c @@ -1355,7 +1355,6 @@ nicvf_sq_add_hdr_subdesc(struct nicvf *nic, struct snd_queue *sq, int qentry, /* Offload checksum calculation to HW */ if (skb->ip_summed == CHECKSUM_PARTIAL) { - hdr->csum_l3 = 1; /* Enable IP csum calculation */ hdr->l3_offset = skb_network_offset(skb); hdr->l4_offset = skb_transport_offset(skb); -- 2.15.0