From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753361AbdKWUiM (ORCPT ); Thu, 23 Nov 2017 15:38:12 -0500 Received: from mx2.suse.de ([195.135.220.15]:56817 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753297AbdKWUiK (ORCPT ); Thu, 23 Nov 2017 15:38:10 -0500 Date: Thu, 23 Nov 2017 21:37:58 +0100 From: Borislav Petkov To: Andy Lutomirski Cc: X86 ML , "linux-kernel@vger.kernel.org" , Brian Gerst , Dave Hansen , Linus Torvalds , Josh Poimboeuf Subject: Re: [PATCH v2 10/18] x86/asm: Remap the TSS into the cpu entry area Message-ID: <20171123203758.j2tazdpstvhhmpmd@pd.tnic> References: <07895bbccbff01d5c6ba3b1a5bf48fab34b92eae.1511325444.git.luto@kernel.org> <20171123195555.ct72tiphayavkffq@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 23, 2017 at 12:15:14PM -0800, Andy Lutomirski wrote: > >> diff --git a/arch/x86/kernel/asm-offsets.c b/arch/x86/kernel/asm-offsets.c > >> index b275863128eb..55858b277cf6 100644 > >> --- a/arch/x86/kernel/asm-offsets.c > >> +++ b/arch/x86/kernel/asm-offsets.c > >> @@ -98,4 +98,7 @@ void common(void) { > >> OFFSET(CPU_TSS_SYSENTER_stack, tss_struct, SYSENTER_stack); > >> /* Size of SYSENTER_stack */ > >> DEFINE(SIZEOF_SYSENTER_stack, sizeof(((struct tss_struct *)0)->SYSENTER_stack)); > >> + > >> + /* Layout info for cpu_entry_area */ > >> + OFFSET(CPU_ENTRY_AREA_tss, cpu_entry_area, tss); > > > > The naming convention of those looks really strange. The beginning is in > > all caps and then small. Can we choose a convention pls. > > This is actually consistent with the rest of the offsets. The > convention is STRUCT_field. Except CPU_TSS_SYSENTER_stack. TSS_STRUCT_SYSENTER_stack I guess. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --