From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752438AbdKXHiY (ORCPT <rfc822;w@1wt.eu>);
        Fri, 24 Nov 2017 02:38:24 -0500
Received: from mail-wm0-f68.google.com ([74.125.82.68]:36425 "EHLO
        mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751675AbdKXHiX (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 24 Nov 2017 02:38:23 -0500
X-Google-Smtp-Source: AGs4zMbkv+0lAWbQaJvERRVzXgi6Hs4r5yR0BGch+1IUZo7FPjHdhM0pHIBdbKTttndVW0SP8+KyRw==
Date: Fri, 24 Nov 2017 08:38:19 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] schedule: use unlikely()
Message-ID: <20171124073819.ejig4akxinmugbnr@gmail.com>
References: <alpine.LRH.2.02.1711131359030.2791@file01.intranet.prod.int.rdu2.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.LRH.2.02.1711131359030.2791@file01.intranet.prod.int.rdu2.redhat.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Mikulas Patocka <mpatocka@redhat.com> wrote:

> A small patch for schedule(), so that the code goes straght in the common
> case.
> 
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
> 
> ---
>  include/linux/blkdev.h |    2 +-
>  kernel/sched/core.c    |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> Index: linux-2.6/include/linux/blkdev.h
> ===================================================================
> --- linux-2.6.orig/include/linux/blkdev.h
> +++ linux-2.6/include/linux/blkdev.h
> @@ -1308,7 +1308,7 @@ static inline bool blk_needs_flush_plug(
>  {
>  	struct blk_plug *plug = tsk->plug;
>  
> -	return plug &&
> +	return unlikely(plug != NULL) &&
>  		(!list_empty(&plug->list) ||
>  		 !list_empty(&plug->mq_list) ||
>  		 !list_empty(&plug->cb_list));

That's an unrelated change.

> Index: linux-2.6/kernel/sched/core.c
> ===================================================================
> --- linux-2.6.orig/kernel/sched/core.c
> +++ linux-2.6/kernel/sched/core.c
> @@ -3405,7 +3405,7 @@ void __noreturn do_task_dead(void)
>  
>  static inline void sched_submit_work(struct task_struct *tsk)
>  {
> -	if (!tsk->state || tsk_is_pi_blocked(tsk))
> +	if (!tsk->state || unlikely(tsk_is_pi_blocked(tsk)))
>  		return;
>  	/*
>  	 * If we are going to sleep and we have plugged IO queued,

Do these changes actually change the generated assembly code?

Thanks,

	Ingo