From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753608AbdKXOyu (ORCPT ); Fri, 24 Nov 2017 09:54:50 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:28259 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752742AbdKXOys (ORCPT ); Fri, 24 Nov 2017 09:54:48 -0500 Date: Fri, 24 Nov 2017 17:53:57 +0300 From: Dan Carpenter To: Ching Huang Cc: Christoph Hellwig , martin.petersen@oracle.com, James.Bottomley@HansenPartnership.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, jthumshirn@suse.de, hare@suse.de Subject: Re: [PATCH 0/3] scsi: arcmsr: add driver module parameter - msi_enable, msix_enable Message-ID: <20171124145357.rtbrqavzne7jkz6l@mwanda> References: <1511400123.9832.14.camel@Centos6.3-64> <20171123125739.GA25627@infradead.org> <1511464359.4370.3.camel@Centos6.3-64> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511464359.4370.3.camel@Centos6.3-64> User-Agent: NeoMutt/20170609 (1.8.3) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 24, 2017 at 03:12:39AM +0800, Ching Huang wrote: > On Thu, 2017-11-23 at 04:57 -0800, Christoph Hellwig wrote: > > On Thu, Nov 23, 2017 at 09:22:03AM +0800, Ching Huang wrote: > > > From: Ching Huang > > > > > > Hi all, > > > > > > The following patches apply to Martin's 4.16/scsi-queue. > > > > > > Patch 1: Add module parameter msi_enable to has a chance to disable msi interrupt if it does not work properly. > > > > > > Patch 2: Add module parameter msix_enable to has a chance to disable msix interrupt if it does not work properly. > > > > Why would it not work properly? > This patch is apply to > https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/tree/?h=4.16/scsi-queue > No, the question is we're adding an option called "msi_enable" which is used to disable MSI interrupts "if it does not work properly". Why is the current code not working properly? Is there a crash or a performance issue? What does the bug in the current code look like from a user perspective? Can you send us a dmesg from a failing system? regards, dan carpenter