From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753707AbdKXPgE (ORCPT <rfc822;w@1wt.eu>);
        Fri, 24 Nov 2017 10:36:04 -0500
Received: from mx2.suse.de ([195.135.220.15]:45619 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752288AbdKXPgD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 24 Nov 2017 10:36:03 -0500
Date: Fri, 24 Nov 2017 07:32:49 -0800
From: Davidlohr Bueso <dave@stgolabs.net>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: James Yang <james.yang@arm.com>, Kim Phillips <kim.phillips@arm.com>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Darren Hart <dvhart@infradead.org>,
        Colin Ian King <colin.king@canonical.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] perf bench futex: benchmark only online CPUs
Message-ID: <20171124153249.ga4gdvsxl4t43uzt@linux-n805>
References: <20171122182528.3a5ac33fa0563b9e25271659@arm.com>
 <20171123150948.GD8789@kernel.org>
 <20171123151100.GE8789@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20171123151100.GE8789@kernel.org>
User-Agent: NeoMutt/20170421 (1.8.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 23 Nov 2017, Arnaldo Carvalho de Melo wrote:

>Em Thu, Nov 23, 2017 at 12:09:48PM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Wed, Nov 22, 2017 at 06:25:28PM -0600, Kim Phillips escreveu:
>> > From: James Yang <james.yang@arm.com>
>> >
>> > The "perf bench futex" benchmarks have a problem when not all CPUs in
>> > the system are online:  perf assumes the CPUs that are online are
>> > contiguously numbered and assigns processor affinity to the threads by
>> > modulo striping.  When the online CPUs are not contiguously numbered,
>> > perf errors out with:

Good catch. Non contiguously numbered cpus was certainly not something I had
considered.

>> >
>> > $ echo 0 | sudo tee /sys/devices/system/cpu/cpu3/online
>> > 0
>> > $ ./oldperf bench futex all
>> > perf: pthread_create: Operation not permitted
>> > Run summary [PID 14934]: 7 threads, each operating on 1024 [private] futexes for 10 secs.
>> >
>> > $
>> >
>> > This patch makes perf not assume all CPUs configured are online, and
>> > adds a mapping table to stripe affinity across the CPUs that are
>> > online.
>>
>> So, have you looked at tools/perf/util/cpumap.c? I think you can use:
>>
>> 	int i;
>> 	struct cpu_map *cpus = cpu_map__new(NULL);
>>
>> 	for (i = 0; i < cpus->nr; ++i) {
>> 		int cpu = cpus->map[i];
>> 		...
>> 	}
>>
>> No?

Ah, I was just thinking there should be something like this in perf already :)

>
>But then, this can be done later, as probably will result in more
>changes, I'm continuing to review the other patches.

Unsure if you're implying otherwise, but I would strongly prefer a v2 was sent
to use the perf's cpumap.c.

Thanks,
Davidlohr