From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753807AbdKXULr (ORCPT ); Fri, 24 Nov 2017 15:11:47 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:37992 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753647AbdKXULq (ORCPT ); Fri, 24 Nov 2017 15:11:46 -0500 Date: Sat, 25 Nov 2017 05:11:43 +0900 (KST) Message-Id: <20171125.051143.1746775828505862683.davem@davemloft.net> To: linux@rasmusvillemoes.dk Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] net: core: export dev_alloc_name_ns From: David Miller In-Reply-To: <20171121003439.10974-1-linux@rasmusvillemoes.dk> References: <20171121003439.10974-1-linux@rasmusvillemoes.dk> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 24 Nov 2017 12:11:45 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rasmus Villemoes Date: Tue, 21 Nov 2017 01:34:37 +0100 > dev_alloc_name_ns and dev_get_valid_name now do exactly the same > thing. Let's expose this functionality as dev_alloc_name_ns > (obviously, a core function like this won't return an invalid > name...). > > Signed-off-by: Rasmus Villemoes If you're going to keep one of the routines, keep the one with the simpler and smaller name, "dev_get_valid_name".