mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Andi Kleen <andi@firstfloor.org>
Cc: Andreas Dilger <adilger@dilger.ca>,
	Tahsin Erdogan <tahsin@google.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: regression: 4.13 cannot follow symlinks on some ext3 fs
Date: Fri, 24 Nov 2017 22:54:23 -0500	[thread overview]
Message-ID: <20171125035423.4rskbrgluqtxztag@thunk.org> (raw)
In-Reply-To: <20171124165102.GS2482@two.firstfloor.org>

On Fri, Nov 24, 2017 at 08:51:02AM -0800, Andi Kleen wrote:
> > I think e2fsck can fix this quite easily, and there really isn't
> > an easy way to revert to the old method if the large xattr feature
> > is enabled.  If you are willing to run a new kernel, you should also
> > be willing to run a new e2fsck.
> 
> It's obviously not enabled on ext3.

Yes, I think it's clear we need to enable a backwards compatibility
support for ext3 file systems, or even all ext4 file systems that
don't have the large xattr feature.

We could have e2fsck offer to fix it, so long as it is being run
manually (e.g., not in preen mode), since it does have the benefit of
releasing unnecessarily allocated 4k blocks for symlinks which are <
60 bytes.

						- Ted

      parent reply	other threads:[~2017-11-25  3:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-23 20:33 Andi Kleen
2017-11-23 22:23 ` Theodore Ts'o
2017-11-23 23:31   ` Andi Kleen
2017-11-24  0:41     ` Andreas Dilger
2017-11-24  2:04       ` Andi Kleen
2017-11-24  6:12         ` Andreas Dilger
2017-11-24 16:51           ` Andi Kleen
2017-11-24 22:03             ` Andreas Dilger
2017-11-24 22:28               ` James Bottomley
2017-11-25  1:42               ` Andi Kleen
2017-11-25 22:32               ` Dave Chinner
2017-11-25 22:45                 ` Reindl Harald
2017-11-25 22:57                   ` Dave Chinner
2017-11-26 15:40                 ` Theodore Ts'o
2017-11-26 21:14                   ` Dave Chinner
2017-11-27 17:11                     ` Theodore Ts'o
2017-11-28  0:42                       ` Dave Chinner
2017-12-04 16:35               ` Jan Kara
2017-11-25  3:54             ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171125035423.4rskbrgluqtxztag@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger@dilger.ca \
    --cc=andi@firstfloor.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tahsin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®